Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The link to a wiki page isn't working in PDF export, from Diagram Menu #94

Closed
ane-gabriela opened this issue Nov 28, 2019 · 1 comment
Closed

The link to a wiki page isn't working in PDF export, from Diagram Menu #94

ane-gabriela opened this issue Nov 28, 2019 · 1 comment
Assignees
@oanalavinia
Labels
Priority: Major Type: Bug
Milestone
1.12.2

Comments

@ane-gabriela
Copy link

@ane-gabriela ane-gabriela commented Nov 28, 2019 •
edited

Steps to reproduce:

  1. Create a diagram
  2. Add some text shapes
  3. Select the text
  4. Add a link to a wiki page
  5. Click on File > Export as > PDF... > Export > Open in New Window
  6. Click on the links

Expected results: The links are working.

Actual results: It appears as the text is shown as a link but there is no link to go to.

Note: The links work when adding a link with a shape, from the plus sign.

ExportLinks
@ane-gabriela ane-gabriela added this to the 1.12 milestone Nov 28, 2019
@mflorea
Copy link
Collaborator

@mflorea mflorea commented Nov 29, 2019

Indeed I haven't handled these type of links. I think they are stored as HTML links in the shape (node) label. We need to extend the diagram-graph-xml-filter module from Diagram.DiagramSheet to add support for filtering these type of links. This issue is more how to do it without duplicating code. Code refactoring might be needed.

@mflorea mflorea removed this from the 1.12 milestone Nov 29, 2019
@mflorea mflorea added this to the 1.13 milestone Nov 29, 2019
@oanalavinia oanalavinia self-assigned this Nov 29, 2019
oanalavinia added a commit to oanalavinia/application-diagram that referenced this issue Dec 3, 2019
@oanalavinia
The link to a wiki page isn't working in PDF export, from Diagram Menu …
b35415b 
…xwikisas#94

* treated the case when the node that has a link is a mxCell, with the value attribute that contains the 'a' tag
@oanalavinia oanalavinia mentioned this issue Dec 3, 2019
Merged
oanalavinia added a commit to oanalavinia/application-diagram that referenced this issue Dec 4, 2019
@oanalavinia
The link to a wiki page isn't working in PDF export, from Diagram Menu …
aefa968 
…xwikisas#94

* refactoring on how to find nodes
oanalavinia added a commit to oanalavinia/application-diagram that referenced this issue Dec 4, 2019
@oanalavinia
The link to a wiki page isn't working in PDF export, from Diagram Menu …
86dc798 
…xwikisas#94

* escape meta-characters
oanalavinia added a commit to oanalavinia/application-diagram that referenced this issue Dec 4, 2019
@oanalavinia
The link to a wiki page isn't working in PDF export, from Diagram Menu …
0e044e5 
…xwikisas#94

* refactor
oanalavinia added a commit to oanalavinia/application-diagram that referenced this issue Dec 6, 2019
@oanalavinia
The link to a wiki page isn't working in PDF export, from Diagram Menu …
3b36ec9 
…xwikisas#94

* used jquery functions instead of regex
oanalavinia added a commit to oanalavinia/application-diagram that referenced this issue Dec 6, 2019
@oanalavinia
The link to a wiki page isn't working in PDF export, from Diagram Menu …
a22c842 
…xwikisas#94

* changed also importLinks for update mxCell tags
* refactoring
oanalavinia added a commit to oanalavinia/application-diagram that referenced this issue Dec 13, 2019
@oanalavinia
The link to a wiki page isn't working in PDF export, from Diagram Menu …
8396a93 
…xwikisas#94

* refactoring
oanalavinia added a commit that referenced this issue Dec 13, 2019
@oanalavinia
The link to a wiki page isn't working in PDF export, from Diagram Men… (
c253466 
#96)

* The link to a wiki page isn't working in PDF export, from Diagram Menu #94
* treated the case when the node that has a link is a mxCell, with the value attribute that contains the 'a' tag

* The link to a wiki page isn't working in PDF export, from Diagram Menu #94
* refactoring on how to find nodes

* The link to a wiki page isn't working in PDF export, from Diagram Menu #94
* escape meta-characters

* The link to a wiki page isn't working in PDF export, from Diagram Menu #94
* refactor

* The link to a wiki page isn't working in PDF export, from Diagram Menu #94
* used jquery functions instead of regex

* The link to a wiki page isn't working in PDF export, from Diagram Menu #94
* changed also importLinks for update mxCell tags
* refactoring

* The link to a wiki page isn't working in PDF export, from Diagram Menu #94
* refactoring
@oanalavinia oanalavinia removed this from the 1.13 milestone Jan 31, 2020
@oanalavinia oanalavinia added this to the 1.12.2 milestone Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oanalavinia oanalavinia

Labels
Priority: Major Type: Bug
Projects
None yet
Milestone
1.12.2
Development

No branches or pull requests
3 participants
@mflorea @oanalavinia @ane-gabriela