Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning/options when uploading a document with the same name but different case #34

Closed
iuliabalan opened this issue Sep 15, 2020 · 2 comments · Fixed by #41
Closed

Comments

@iuliabalan
Copy link

Currently, when we upload a document on File Manager if the document's name is only different by lower/upper case a new page is created (since XWiki is case sensitive).
To not have duplicated documents in FM (that are only different by the name's lower/upper case) it would be nice to have a warning displayed when uploading a document, like "This document already exists. Do you want to replace it?" and the option to replace the existing document, create a new one, or cancel the upload.

@iuliabalan
Copy link
Author

Confirmed with @mflorea that the user would have 3 options:

  • upload using the original file name (case sensitive)
  • upload using the existing attachment name (case insensitive)
  • abort the upload

Thanks!

@mflorea mflorea added this to the 2.4 milestone Oct 28, 2020
@oanalavinia oanalavinia self-assigned this Nov 18, 2020
oanalavinia added a commit to oanalavinia/application-filemanager that referenced this issue Dec 9, 2020
…different case xwikisas#34

* when a similar file is uploaded a modal is displayed with the upload actions that can be selected
oanalavinia added a commit to oanalavinia/application-filemanager that referenced this issue Dec 9, 2020
…different case xwikisas#34

* forgot to add translations
* update naming
oanalavinia added a commit to oanalavinia/application-filemanager that referenced this issue Dec 9, 2020
oanalavinia added a commit to oanalavinia/application-filemanager that referenced this issue Dec 9, 2020
oanalavinia added a commit to oanalavinia/application-filemanager that referenced this issue Dec 9, 2020
…different case xwikisas#34

* differentiate option files that have the same name
oanalavinia added a commit to oanalavinia/application-filemanager that referenced this issue Jan 19, 2021
oanalavinia added a commit to oanalavinia/application-filemanager that referenced this issue Jan 19, 2021
oanalavinia added a commit to oanalavinia/application-filemanager that referenced this issue Jan 19, 2021
oanalavinia added a commit to oanalavinia/application-filemanager that referenced this issue Feb 2, 2021
oanalavinia added a commit to oanalavinia/application-filemanager that referenced this issue Feb 3, 2021
oanalavinia added a commit to oanalavinia/application-filemanager that referenced this issue Feb 3, 2021
oanalavinia added a commit to oanalavinia/application-filemanager that referenced this issue Feb 3, 2021
oanalavinia added a commit that referenced this issue Feb 3, 2021
…different case #34 (#41)

* when a similar file is uploaded a modal is displayed with the upload actions that can be selected
@oanalavinia
Copy link

Result:

When the similar file is uploaded, a popup is displayed with the upload actions that can be selected:

  • upload new file: a new filemanager file is created with the uploaded file name

  • replace:

    • the replace action means that the already existing filemanager file / document is used and this file will be uploaded with that name, creating a new attachment version on the selected page
    • if multiple similar files are found, the user needs to select which is the replace one
  • abort: don't upload the current file (if other file conflicts are present for the uploads in queue, this action is not applied to them and other popups will be shown)

The modal is displayed also if a file with the same name is uploaded

modal2

modal1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment