Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A failed upload is not always properly notified #4

Closed
nicolaslemoine opened this issue Oct 19, 2018 · 1 comment
Closed

A failed upload is not always properly notified #4

nicolaslemoine opened this issue Oct 19, 2018 · 1 comment
Assignees
Milestone

Comments

@nicolaslemoine
Copy link

@nicolaslemoine nicolaslemoine commented Oct 19, 2018

For instance, using the antivirus app, when the attachment is rejected, there is no error message

@mflorea mflorea self-assigned this Oct 19, 2018
@mflorea mflorea added this to the 2.3 milestone Oct 19, 2018
mflorea added a commit that referenced this issue Oct 26, 2018
* Change the file icon to indicate that the upload failed.
mflorea added a commit that referenced this issue Oct 26, 2018
* Check if the upload response matches our expectations.
* The cancel upload button is not displayed if the upload fails so we don't need the margin on the right.
mflorea added a commit that referenced this issue Oct 26, 2018
* Improve the icon alignment on the latest version of XWiki
* Remove the margin below the progress bar.
@mflorea
Copy link
Collaborator

@mflorea mflorea commented Oct 26, 2018

screenshot_2018-10-26 file manager - xwiki 1

@mflorea mflorea closed this Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants