Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update root pom artifact id from "application-filemanager-pom" to "application-filemanager" #63

Closed
slauriere opened this issue Oct 11, 2022 · 0 comments
Assignees
Milestone

Comments

@slauriere
Copy link

slauriere commented Oct 11, 2022

By default the Maven release plugin uses the root parent name as tag, hence using "application-filemanager" as artifact id will make the release process simpler and will avoid ending up with release tags such as application-fliemanager-pom-2.5.5. As mentioned by @mflorea, the update is safe because com.xwiki.filemanager:application-filemanager was never used. It's not the case for the contrib version however: where the UI module has:

<xwiki.extension.features>
  tdelafosse:file-manager-application,
  org.xwiki.contrib:application-filemanager
</xwiki.extension.features>
@slauriere slauriere self-assigned this Oct 11, 2022
@slauriere slauriere added this to the 2.5.6 milestone Oct 11, 2022
slauriere added a commit that referenced this issue Oct 11, 2022
@trrenty trrenty modified the milestones: 2.6.1, 2.6 May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants