Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 'groups' column filter (select input) causes a Java Heap error in wikis with large amounts of groups #49

Closed
Enygma2002 opened this issue Sep 17, 2020 · 1 comment

Comments

@Enygma2002
Copy link
Member

Because of the type of the groups column ('groups': {'type': 'list',`), the livetable macro generates the select filter which is causing problems when the wiki has a huge number of groups (e.g. 100K) and all of them are loaded into memory to be displayed as select options.

Changing the type to text keep the column without the problem filter. If we want to keep the filtering helper, the select could maybe be replaced with a suggest text input, showing suggestions based on the user's input.

The screenshot is from an older version, but the problem is present in the latest version as well:
flash-messages-manyGroups-javaHeapError

@oanalavinia oanalavinia self-assigned this Sep 17, 2020
@mflorea
Copy link

mflorea commented Sep 28, 2020

suggest type is available since 9.8. We should use it.

@mflorea mflorea added this to the 1.5 milestone Sep 29, 2020
ignatescustefan added a commit that referenced this issue Sep 30, 2020
…ap error in wikis with large amounts of groups

*changed groups column type from `list` to `suggest`
mflorea added a commit that referenced this issue Oct 7, 2020
The 'groups' column filter (select input) causes a Java Heap error in wikis with large amounts of groups #49
@mflorea mflorea closed this as completed Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants