Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate the need of programming rights #46

Closed
oanalavinia opened this issue Aug 31, 2021 · 0 comments · Fixed by #47
Closed

Investigate the need of programming rights #46

oanalavinia opened this issue Aug 31, 2021 · 0 comments · Fixed by #47
Assignees
Milestone

Comments

@oanalavinia
Copy link

oanalavinia commented Aug 31, 2021

The problem was discussed on the initial issue #43.
Following the same steps to reproduce, the user will not be able to vote and will get a "Error while voting" error.

As it was discussed on the issue, an investigation should be performed to see why the programming rights are needed in order to update the code or the documentation.

trrenty added a commit to trrenty/application-ideas that referenced this issue Nov 2, 2021
@trrenty trrenty linked a pull request Apr 14, 2022 that will close this issue
trrenty added a commit that referenced this issue May 11, 2022
* Investigate the need of programming rights #46

* Code changes

Migrated the code from IdeasVoteService to Java. Modified the JavaScript extension to make the call to the correct URL. Modified all the files that required the JS code.

* Added unit tests for DefaultIdeasManager

* [Misc] Code improvements

* [Misc] Code improvements

* [Misc] Code changes

* [Misc] Code changes

Created a new REST resource to update the supporters or opponents of a given Idea.
Refactored the IdeasManager code to reduce code duplication.
Separated the REST model from the domain Model. Created a Utility class to convert between the two.
Added a new public method to the IdeaManager for the removal of votes.

* [Misc] Code changes

* Deleted IdeasVoteResource but inregrated its functions in IdeasResource
* Use query parameter to determine if the vote is for or against
* Removed parameter from removeVote functions

* [Misc] Code improvements

* Changed the page comment on save to be more accurate
* Changed the Idea model slightly
* Removed the public acces modifier of the DefaultIdeasManagerTest class
* Fixed IdeasResource test
* When voting, used one request to the server rather than two

* [Misc] Upgrade Licensor dependency to 1.22.1

* [Misc] Code Changes

* Escaped translated strings in JS
@trrenty trrenty self-assigned this May 11, 2022
@trrenty trrenty added this to the 1.13.3 milestone May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants