Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The duration in meeting doesn't automatically change #33

Closed
CostiChD opened this issue Aug 30, 2018 · 3 comments
Closed

The duration in meeting doesn't automatically change #33

CostiChD opened this issue Aug 30, 2018 · 3 comments
Assignees
Milestone

Comments

@CostiChD
Copy link

@CostiChD CostiChD commented Aug 30, 2018

Issue: https://jira.xwiki.org/browse/XAMEETINGS-142

Steps to reproduce:

1 .Click on Meetings from Applications Panel
2. Add a new meeting with a specified Duration e.g. 1h 30 min
3. Click on Meeting again
4. Click on Calendar
5. Resize the meeting duration e.g. drag the box to have a 3h Duration
6. Click on Meetings
7. Expected results: The Duration is automatically changed in the LiveTable for that meeting.

Actual results: The Duration remains at "1h 30 min".

NOTE: The solution is to Edit the meeting, refresh the page (ctrl + f5) then press Save & View. This won't change the Duration in view mode so you have to refresh the page again for that to be changed.

@CostiChD CostiChD added this to the 1.9 milestone Aug 30, 2018
@CostiChD CostiChD self-assigned this Aug 30, 2018
@CostiChD
Copy link
Author

@CostiChD CostiChD commented Aug 30, 2018

NOTE 2: After resizing the meeting duration( drag in calendar overview), if you just go to that meeting page(here the value will still be the old one until you refresh the page) the duration will be updated in the livetable.

@lucaa
Copy link

@lucaa lucaa commented Sep 19, 2018

Please note that all duration-related issues should be looked at together with https://jira.xwiki.org/projects/XAMEETINGS/issues/XAMEETINGS-130 - I think before we invest time in fixing the issues related to the current duration implementation we should consider migrating to a proper duration management.

@CostiChD
Copy link
Author

@CostiChD CostiChD commented Sep 20, 2018

An approach would be just to keep the duration property and use the custom display to show it in the livetable(from the WebHome), like it was before with the durationString property. Also (using custom display) we would need to get the duration(using 2 inputs: one for the hours and one for the minutes) when editing the meeting.
I dont see the point of using an endDate property because usually meetings have a shorter duration than 24 hours and this could be done just with the duration property.
Another thing that we should consider is that the "duration" property actually has the type Static List, even tho it keeps a number.(this is the reason why the Duration sorting does not work right now in the livetable)
This way we can get rid of durationHour, durationMinutes, durationString, calc and hasBeenEdited properties and keep just the "duration" property.

@acotiuga acotiuga modified the milestones: 1.9, 2.0 Nov 1, 2018
oanalavinia added a commit to oanalavinia/application-meeting that referenced this issue Jan 16, 2019
acotiuga added a commit that referenced this issue Jan 16, 2019
* updated properties from livetable and due to changes made in #45 the livetable is now updating
@oanalavinia oanalavinia assigned oanalavinia and unassigned CostiChD Jan 16, 2019
@acotiuga acotiuga modified the milestones: 2.0, 1.9.1 Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants