Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meeting's Title isn't changed #47

Closed
ane-gabriela opened this issue Feb 4, 2019 · 3 comments
Closed

Meeting's Title isn't changed #47

ane-gabriela opened this issue Feb 4, 2019 · 3 comments
Assignees
Milestone

Comments

@ane-gabriela
Copy link

@ane-gabriela ane-gabriela commented Feb 4, 2019

Steps to reproduce:

  1. Click on Meeting App from Apps Panel
  2. Edit a meeting
  3. Change the Meeting's title
  4. Click on Save & View

Expected results: The changes are saved.

Actual results: The title doesn't change - with Admin and simple user.

Environment: Windows 10, XWiki 10.11.2 with MySQL 5.7 and Edge 18, Meeting Application (Pro) 1.9.1

adminmeetingcreated
newtitle
result1
result2

@ane-gabriela ane-gabriela added this to the 2.0 milestone Feb 4, 2019
@oanalavinia oanalavinia self-assigned this Apr 9, 2019
oanalavinia added a commit to oanalavinia/application-meeting that referenced this issue Apr 9, 2019
* use 'meetingTitle' property
oanalavinia added a commit to oanalavinia/application-meeting that referenced this issue Apr 23, 2019
* deleted meetingTitle prop since the page already has a title
* added migration page for the deprecated property
oanalavinia added a commit to oanalavinia/application-meeting that referenced this issue May 2, 2019
* fixed tests
* moved migration macro to a new page in Migrations space
* show migration error only if the user is admin and check programming right
* should delete only the deprecated property that what deleted in this release
oanalavinia added a commit to oanalavinia/application-meeting that referenced this issue May 2, 2019
* better naming of variables
oanalavinia added a commit to oanalavinia/application-meeting that referenced this issue May 6, 2019
* put back the dates that shouldn't be changed
@oanalavinia oanalavinia closed this May 6, 2019
@oanalavinia oanalavinia removed this from the 2.0 milestone May 6, 2019
@oanalavinia oanalavinia added this to the 1.9.5 milestone May 6, 2019
@oanalavinia
Copy link

@oanalavinia oanalavinia commented May 6, 2019

The title of the document can be changed now just using wiki mode, not from the default editor.

@lucaa
Copy link

@lucaa lucaa commented Jun 14, 2020

@oanalavinia I am trying to understand, in the context of #66, what was done for this issue and what's the resolution that lead to it being considered resolved (and thus closed).

If I understand correctly (please confirm or correct me):

  • the issue was related to the meeting class having a specific field, the meetingTitle property, which was not properly used / updated with what the user was typing
  • the solution was to remove this property and let the meeting document use the document title, normally, like any other document
    • part of the resolution is that, in order to change the title of the meeting, one now needs to go through the Edit -> Wiki menu and update the document title in the edit wiki mode.

If I am right, the resolution of having the user go through the edit wiki mode to change the title of a meeting is not OK at all, for various reasons:

  • Any other edit mode besides the default one is only accessible to advanced users. We shouldn't assume that only advanced users should be able to change the meeting title
    • even as an advanced user, I have no way to know that I need to go through a completely separate edit mode (and an additional edit step) in order to update the title
  • there is nothing that is technically preventing us from adding the title input in the default edit form (should use a computed field, like app within minutes do)

@oanalavinia
Copy link

@oanalavinia oanalavinia commented Jun 15, 2020

Hi @lucaa !
The idea of the fix was indeed to let a meeting entry use the title of the page, like any other document.

The regression caused by this is resulted from the fact that, from what I remember, I didn't took into consideration at that time that any other edit mode, besides the default one, would be visible only to advanced users.

I'll provide a fix to the new issue created. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants