Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the template provider for the meeting to replace the usage of the deprecated "spaces" property #74

Closed
lucaa opened this issue Nov 13, 2020 · 3 comments
Assignees
Milestone

Comments

@lucaa
Copy link

lucaa commented Nov 13, 2020

Because of this issue https://jira.xwiki.org/browse/XWIKI-18060 and the fact that the meeting template provider is using the spaces property, the behaviour of the meeting template provider is incomprehensible: the page of the template provider says there is no restriction but still, the template is not available everywhere (see screenshots of the linked ticket).

@lucaa lucaa added this to the 1.10 milestone Nov 13, 2020
@lucaa
Copy link
Author

lucaa commented Nov 13, 2020

Also, please check if other applications may be in this case.
Diagram app was for a while (until its issue 172 was fixed), but other apps should get fixed as well.

@acotiuga acotiuga self-assigned this Nov 13, 2020
acotiuga added a commit that referenced this issue Nov 13, 2020
@lucaa
Copy link
Author

lucaa commented Nov 13, 2020

Note that the above fix is also bringing a behaviour change, as creationRestrictions is not 100% equivalent to spaces:

  • before, the template was visible only in the Meeting space and pages could be created only in the Meeting space
  • after, the template is visible anywhere, but when choosing this template the page is created in the Meeting space.

I'm fine with the new behaviour, I think it's even better (although I would check to verify that it corresponds to what other applications are doing), just making sure it's mentioned on the ticket as a consequence and a decision, rather than a side-effect.

acotiuga added a commit that referenced this issue Nov 13, 2020
…the deprecated "spaces" property #74

* make sure to also keep the template visible only in Meeting space, as it was before
@acotiuga
Copy link

There was no discussion about changing the behaviour, so I'm fixing it to be just the same as before.
Also, there were some different approaches among the other applications so there is not only one rule, or a general one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants