Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meeting End date can be set to a date/hour prior to the Start date #78

Closed
ane-gabriela opened this issue Dec 9, 2020 · 4 comments
Closed

Comments

@ane-gabriela
Copy link

ane-gabriela commented Dec 9, 2020

Steps to reproduce:

  1. Create a new meeting with a selected Start Date and time eg. "08/12/2020 16:00"
  2. Choose an End Date prior to the Start Date eg. "03/12/2020 09:30"

Expected results: The user isn't allowed to select a date/hour prior to the Start Date.

Actual results: The user can select any date and hour, with the Date picker or by writing in the text input field. The meeting duration is not calculated properly also.

MeetingDuration

Environment: XWiki 12.6.5 with Chrome 87, Meeting Application (Pro) 1.11

It appears that issue 65 wasn't fixed.

@mflorea
Copy link

mflorea commented Dec 10, 2020

@ignatescustefan please look at this ASAP. If the issue was not fixed in #65 then I'd like to know why. The steps to reproduce indicated by @ane-gabriela are fairly simple so how come you didn't catch this? Thanks.

@ignatescustefan
Copy link

Hello! I first tested the bug for XWiki 9.11 and it reproduced. After that, I fixed that and tested it on the minimum supported version. Now, I did not take into consideration the fact that the fix should be also tested on the reported version. Looking now on it.

image

@mflorea
Copy link

mflorea commented Dec 10, 2020

I fixed that and tested it on the minimum supported version.

That's very good. Please double check if the issue is fixed on 9.11 with the released version of the Meeting application.

the fix should be also tested on the reported version.

I understand. Indeed, it would be good to test also on the XWiki version where the issue was reported. Let us know if you can reproduce on 12.6.5. Thanks.

mflorea added a commit that referenced this issue Dec 16, 2020
Issue #78: Meeting End date can be set to a date/hour prior to the Start date
@ignatescustefan
Copy link

ignatescustefan commented Dec 22, 2020

It was needed to listen to the dp.change event, because the change event is not triggered anymore on the new Date Time Picker.
User interaction after the fix:
record

@ignatescustefan ignatescustefan modified the milestones: 2.0, 1.11.1 Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants