New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meeting addresses with accents in the name (french) are not properly found on the map #8

Closed
lucaa opened this Issue May 7, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@lucaa
Copy link

lucaa commented May 7, 2018

When making a meeting at an address like this:

"1 Avenue de Ségur, 75007 Paris"

and checking the "display map" checkbox, it does not display properly on the map: the map is displayed but the place it shows on the map is not the correct place for this address.

The reason is the accent in the name of the address, somehow the address that is being searched for is "Avenue du S".

If the address is changed to "1 Avenue de Segur, 75007 Paris" , the map is correct.

@lucaa

This comment has been minimized.

Copy link

lucaa commented May 7, 2018

I inspected a bit the network requests and apparently the problem is in the geolocator service:
https://maps.googleapis.com/maps/api/js/GeocodeService.Search?4s1%20Avenue%20de%20S%5Cu00E9gur%2C%2075007%20Paris&7sUS&9sen-US...

The parameters sent to it contain the encoded accent:

image

and in the response the found address seems to stop at the accent:

image

@acotiuga

This comment has been minimized.

Copy link
Collaborator

acotiuga commented May 7, 2018

This is a Map macro issue: https://jira.xwiki.org/browse/MAP-15. I will use this issue to commit the Map macro dependency's version update.

@acotiuga acotiuga self-assigned this May 7, 2018

@acotiuga acotiuga added this to the 1.9 milestone May 7, 2018

acotiuga added a commit that referenced this issue May 9, 2018

Meeting addresses with accents in the name (french) are not properly …
…found on the map #8

* the issue was fixed in the Map macro.

@acotiuga acotiuga closed this May 9, 2018

@acotiuga acotiuga modified the milestones: 1.9, 1.8.2 May 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment