New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear the default start date #9

Closed
acotiuga opened this Issue May 7, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@acotiuga
Copy link
Collaborator

acotiuga commented May 7, 2018

All meetings have the start date set to 07/07/2016 15:45: https://jira.xwiki.org/browse/XAMEETINGS-149.

@acotiuga acotiuga added this to the 1.9 milestone May 7, 2018

@acotiuga acotiuga self-assigned this May 7, 2018

@acotiuga acotiuga changed the title Clear the default date Clear the default start date May 7, 2018

acotiuga added a commit that referenced this issue May 7, 2018

Clear the default start date #9
* It looks like the 'Empty Is Today' is not working as expected.
* With this property enabled, the metting template will have the date empty and on any save the date will be updated with the current one and that value will be used in all the new meetings.

@acotiuga acotiuga closed this May 7, 2018

@lucaa

This comment has been minimized.

Copy link

lucaa commented May 7, 2018

you wrote in the commit comment:
"It looks like the 'Empty Is Today' is not working as expected."
and you also deactivated the "empty is today" for the meeting start date.

well, it does work as expected: if you're trying to save a document with an empty start date, it fills in the date of today. This applies to the template as well, and the values from the template are used when creating a new document.
The issue is caused by careless saving and commit of the template document, not by the functioning of the "empty is today" option, imo. Otherwise put, the start date of the meeting can be "empty is today" - and probably should - , we just need to be extra careful about the meeting template we pack in the application.

@acotiuga

This comment has been minimized.

Copy link
Collaborator

acotiuga commented May 7, 2018

OK, I see the point, let me fix this. Thanks!

acotiuga added a commit that referenced this issue May 7, 2018

Clear the default start date #9
* revert the disabling of the 'Empty Is Today' property, from the previous commit as the change was wrong.
@lucaa

This comment has been minimized.

Copy link

lucaa commented May 7, 2018

note that being able to create meetings with an empty date without that date being filled in upon save (empty is today on false) is probably something that can be interesting as a feature as well, it's not necessarily "wrong". My intention in the initial remark was to highlight that it's a different decision than the current issue, the current issue is only about the date that is saved in the template.

@acotiuga

This comment has been minimized.

Copy link
Collaborator

acotiuga commented May 7, 2018

Wrong as not needed in the previous commit.

@acotiuga acotiuga modified the milestones: 1.9, 1.8.2 May 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment