Add the option to add the calendar class object to a used calendar macro.

[ChiuchiuSorin]

To further improve this issue, we added the option to create an improvement to allow an user to add the missing object, granting him access to further customizations (like color schemes) and displaying the calendar in the overview. Otherwise, the object is added automatically when creating a new page with the Calendar template:

This info box will be displayed only on those mocca calendar macros that do not have the calendar class object on the page and that have the Show events from ... (filter) field set to page (other options being space and wiki). So only calendars displaying events from the current page where the macro is used and without the calendar class object will have the message displayed.

[lucaa]

@ChiuchiuSorin and @oanalavinia I must admit that I don't understand this feature. I did read the comments and images from the pull request as well as the message in the infobox, I still don't understand what this feature is doing...

Can you please explain the objective in this ticket, as this is the request that describes the need?

More specifically, what is strange to me is the "adding an object to a macro"... you can't add an object to a macro, you can add it to a page. So the option to transform a page into a calendar definition (by adding the object) will be displayed on all pages that display a calendar? Which calendar? Any calendar or the mocca calendar macro? Any calendar is not ok, the mocca calendar may be ok. The option is available to all users ? Only users with edit rights?

Also, this is assuming that there is no legitimate use of this type of calendar macro on a page which is not a calendar page, which may or nor be true - if it's not true then the fact that this macro could be added on any page was a defect in the first place. Is there a way to dismiss this message (maybe an optional parameter of the calendar macro), just in case that usecase exists...

[ChiuchiuSorin]

Hi! while working on this issue, we realized that the problem was actually coming from the fact that the macro was missing the calendar class object. After fixing it, we decided to create an improvement to allow an user to add the missing object, granting him access to further customizations (like color schemes) and displaying the calendar in the overview. Otherwise, the object is added automatically when creating a new page with the Calendar template.

This info box will be displayed only on those mocca calendar macros that do not have the object on the page and that have the Show events from ... (filter) field set to page (other options being space and wiki). So only calendars displaying events from the current page where the macro is used and without the calendar class object will have the message displayed. Also, I don't think there is any reason to restrict the macro usage on any page.