Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entries from default calendar 'Other Events' have white text color, although the default set color is black #19

Closed
ilieandriuta opened this issue Nov 12, 2018 · 0 comments
Assignees
Milestone

Comments

@ilieandriuta
Copy link

STEPS TO REPRODUCE

  1. Go to Calendar Pro homepage
  2. Click on 'Other Events' calendar from calendars livetable on the bottom of the page
  3. Create some entries
  4. Observe the color displayed on the 'TEXT COLOR OF ENTRIES IN THE CALENDAR VIEW' on the top of the page and the actual text color of the entries

EXPECTED RESULTS

As the color set on the 'TEXT COLOR OF ENTRIES IN THE CALENDAR VIEW' is black by default, also the text color of the new created entries have black color.

ACTUAL RESULTS

Although the default set text color is black, the entries text color is white.

default_calendar_color

@ilieandriuta ilieandriuta added this to the 2.9 milestone Nov 12, 2018
@oanalavinia oanalavinia self-assigned this Nov 13, 2018
oanalavinia added a commit to oanalavinia/application-mocca-calendar that referenced this issue Jan 25, 2019
…lthough the default set color is black xwikisas#19

* the textColor property didn't had a default property
acotiuga pushed a commit that referenced this issue Jan 29, 2019
…lthough the default set color is black #19 (#22)

* the textColor property didn't had a default property
@acotiuga acotiuga modified the milestones: 2.9, 2.8.1 Feb 5, 2019
ClemensRobbenhaar added a commit that referenced this issue Sep 24, 2021
Actually merge from the xwiki-contrib version.

The main new feature (recurrent events) are still disabled
after the merge as some UI elements where not really stable, namely
the date pickers. See MoccaCalendarEventSheet for the simple
"#if(false)" clauses disabling it.

Conflicts have been resolved as:

MoccaCalendarTranslations.*
   - added translations for recurrent events
   - added missing MoccaCalendarMacroTranslations from e.x.o version
     or add placeholders for them where missing

Code/WebHome
   - the automatic merge confused the page with the (also moved)
     MoccaCalendarEventLiveTableResults

Code/Macro
  - the improved "Delete event" modal (#14)
    needed to be merged with the "delete all instances" implementation
    it now has an extra buttom "delete all" only shown for recurrent events
  - upstream added newPageNameUrl, dateCheckUrl, deleteEventInstanceUrl to calendar.Helper
    for the new separate services split from the JSONService; now list each
    of them on a separate line for better reading

JSONService -> Code/JSONService, etc.
  - upstream service got distributed to several services pages in Code.
  - use of naming service (in #42) is now in Code.NewEventNameService
  - scrapped use of Calendar.Translations which are WIKI level (#26)
    now in Code.JSONService, too

Event/WebHome
  - probably because of the page move setting the text color
    (#19 / #22: set default to black) needed to be restored

MoccaCalendarSheet
  - the color picker fields had been reformatted upstream
    kept version from this repository

MoccaCalendarEventSheet
  - conflict between extracting a "getDateFormat" macro out of the "displayDate" macro
    and upstream change in this macro
  - conflict between new input fields for recurrent events upstream
    and a modification for the calender selection field
  - the "hidden" filter added for #49 has been migrated
    to the corresponding API code

and also the unavoidable version number clashes in the pom.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants