Skip to content

Missing and incorrect french translations on the calendar page #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lucaa opened this issue Nov 18, 2020 · 2 comments
Closed

Missing and incorrect french translations on the calendar page #47

lucaa opened this issue Nov 18, 2020 · 2 comments
Assignees
@lucaa
Labels
Priority: Minor Type: Bug
Milestone
2.9.2

Comments

@lucaa
Copy link

lucaa commented Nov 18, 2020

image
lucaa added a commit that referenced this issue Nov 19, 2020
@lucaa
Missing and incorrect french translations on the calendar page #47
fc3294c 
* Added french translation for the missing key and fixed some other translations
@lucaa lucaa added this to the 3.0 milestone Nov 19, 2020
@lucaa
Copy link
Author

lucaa commented Nov 19, 2020

Added the missing traslation from this screenshot (did not check if others are missing as well) and fixed these wrong translations and others that i've noticed as being wrong. Closing this ticket for now, if I find other translations to fix until next release, I may fix them under this same issue as well.

@lucaa lucaa closed this as completed Nov 19, 2020
@acotiuga acotiuga modified the milestones: 3.0, 2.9.2 Nov 23, 2020
ClemensRobbenhaar added a commit that referenced this issue Oct 3, 2021
@ClemensRobbenhaar
Allow to show meetings in the calendar #47
2acbfd2 
development savepoint:
- add new "MeetingEventService" to provide event instances
  from meeting objects
- new "utils" package with helpers to reduce common code

still duplicate code left, and UI is fully unaware of the
new events, which causes the detail/edit view to be broken
ClemensRobbenhaar added a commit that referenced this issue Oct 3, 2021
@ClemensRobbenhaar
Allow to show meetings in the calendar #47
3b5859d 
development savepoint:
- a bit less code, although creating "EventInstance"
  objects from the data objects seems a bit too specific
  to be extracted into common code
ClemensRobbenhaar added a commit that referenced this issue Oct 3, 2021
@ClemensRobbenhaar
Allow to show meetings in the calendar #47
a50e20a 
- extract the preliminary "EventSource" from the MeetingsEventSource
  so the script service does not need to know about it
- events can be flagged a modifiable or movable
  (thought the latter is not repected by the UI yet)
- added a "generic view" sheet that can be used to display
  events in case the "normal" view of that page is
  not appropriate. this view is used to display
  meetings (and currently all other potential other
  EventSources as well).
- also lots of formatting / checkstyle tweaks
ClemensRobbenhaar added a commit that referenced this issue Nov 4, 2021
@ClemensRobbenhaar
Allow to show meetings in the calendar #47
b75e2f7 
* add configuration to switch event sources on and off
  globally in the administration section
* also move the "meetings" related classes in a package
  of its own within the "internal" package
* add a new section in the wiki administration to enable
  or disable extra event sources globally
  the part to enable them locally for every calendar
  is still missing, however
ClemensRobbenhaar added a commit that referenced this issue Nov 30, 2021
@ClemensRobbenhaar
Allow to show meetings in the calendar #47
32b3bb4 
* b/w compat change for XWiki 11.10.x
ClemensRobbenhaar added a commit that referenced this issue Nov 30, 2021
@ClemensRobbenhaar
Allow to show meetings in the calendar #47
94a524b 
* add configuration per calendar page from where
  to add new events for each source
  somewhat patchy: the "active" flag is not taken into account
ClemensRobbenhaar added a commit that referenced this issue Dec 1, 2021
@ClemensRobbenhaar
Allow to show meetings in the calendar #47
d2fe7b1 
- add macro parameter "filterDoc" allowing to set
  the root of the query for calendar items to
  another location - as per customisations by @lucaa
ClemensRobbenhaar added a commit that referenced this issue Dec 15, 2021
@ClemensRobbenhaar
Allow to show meetings in the calendar #67
cf3300a 
- actually enable the local "active" flag
  for each calendar
- also hit "format source" with ... consequences
  sorry for the big diff
- note: issue number in previous commits with
  the same title should have been #67 instead of #47,
  either
@lucaa
Copy link
Author

lucaa commented Feb 25, 2022

All the commits on this ticket by @ClemensRobbenhaar were actually for issue #67 instead of this one.

@lucaa lucaa mentioned this issue Feb 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucaa lucaa

Labels
Priority: Minor Type: Bug
Projects
None yet
Milestone
2.9.2
Development

No branches or pull requests
2 participants
@lucaa @acotiuga