Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong documentation of the "first day of the week" parameter of the calendar macro #54

Closed
lucaa opened this issue Nov 25, 2020 · 2 comments
Assignees
Milestone

Comments

@lucaa
Copy link

lucaa commented Nov 25, 2020

The hint of the First day of the week parameter of the calendar macro instructs to use 6 for Monday, when the correct value is actually 1, 6 is for Saturday:

image

The other available languages of the application should be checked as well.

@oanalavinia
Copy link

oanalavinia commented Nov 26, 2020

Related to #41 , the documentation should also be updated since it says Leave empty for Sunday, but in case the wiki language is set, for example, to Spanish, leaving firstDay empty will display Monday as the first day, not Sunday.

An idea could be to say that an empty value means the default day of the locale.
Or maybe the translations should be updated to specify the default first day of the locale (for example, in case of Spanish to have leave empty for Monday)

@lucaa
Copy link
Author

lucaa commented Dec 18, 2020

Or maybe the translations should be updated to specify the default first day of the locale (for example, in case of Spanish to have leave empty for Monday)

As I said on the other issue, you can have the same language for multiple locales, so I am not sure we'd necessarily be getting it right if we'd put the info in the translation. So I would say the documentation should say the default of the current locale would be used and that's it. This is also interesting for a multilanguage wiki, where not setting any value would (I think) use the default day of the language currently used (sunday for people looking at the wiki in en_US locale, monday for people looking at it with fr_FR).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants