New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The editor is not loading when creating a new event in the calendar #7

Closed
acotiuga opened this Issue Mar 6, 2018 · 4 comments

Comments

Projects
None yet
4 participants
@acotiuga
Copy link
Collaborator

acotiuga commented Mar 6, 2018

editornotloading

@acotiuga acotiuga added this to the 2.8 milestone Mar 6, 2018

@ane-gabriela

This comment has been minimized.

Copy link

ane-gabriela commented Jul 4, 2018

Linked to https://jira.xwiki.org/browse/MOCCACAL-111 which was fixed.

acotiuga added a commit that referenced this issue Jul 5, 2018

The editor is not loading when creating a new event in the calendar #7
* for the moment, keep the pure text editor and it would be nice in the future to support the default wysiwyg editor

@acotiuga acotiuga closed this Jul 5, 2018

@acotiuga acotiuga self-assigned this Jul 5, 2018

@lucaa lucaa reopened this Sep 6, 2018

@lucaa

This comment has been minimized.

Copy link

lucaa commented Sep 6, 2018

Reopening, as the fix for MOCCACAL-111 was imprecisely applied and the issue still reproduces.

As far as I can understand, the fix for MOCCACAL-111 was to change the MoccaCalendarEventClass (which holds the events of the calendar) while the fix applied for this issue is changing MoccaCalendarClass (which holds the definition of a calendar) .

@mflorea

This comment has been minimized.

Copy link

mflorea commented Sep 7, 2018

@acotiuga please use cherry-pick -x to take commits from contrib, otherwise:

  • you can easily do mistakes, like in this case
  • you don't give credits to the real commit author, which is not fair

acotiuga added a commit that referenced this issue Sep 7, 2018

@acotiuga

This comment has been minimized.

Copy link
Collaborator

acotiuga commented Sep 7, 2018

Fixed in e199baf. Sorry for the mistake and thanks for guidance.

@acotiuga acotiuga modified the milestones: 2.8, 2.7.4 Sep 18, 2018

@acotiuga acotiuga closed this Sep 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment