Skip to content

The Office365 application cannot be installed with OpenID Connect version > 2.0.0 #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aubincleme opened this issue Jul 31, 2023 · 3 comments · Fixed by #27
Closed

The Office365 application cannot be installed with OpenID Connect version > 2.0.0 #25

aubincleme opened this issue Jul 31, 2023 · 3 comments · Fixed by #27
Assignees
@oanalavinia
Labels
Priority: Major Type: Bug
Milestone
1.11.1

Comments

@aubincleme
Copy link
Member

aubincleme commented Jul 31, 2023 •
edited
Loading

This issue was reported by a support client. When trying to install the extension, the client gets the following error :

image
@aubincleme aubincleme changed the title The O The Office365 application cannot be installed on XWiki 14.10.13 Jul 31, 2023
@aubincleme
Copy link
Member Author

Closing as it turns out that the installation works well on a vanilla version of XWiki 14.10.13. The extension net.minidev:json-smart may be already installed by another dependency.

@aubincleme aubincleme reopened this Jul 31, 2023
@aubincleme
Copy link
Member Author

Re-opening the issue as I have found the root cause : it turns out that this extension cannot be installed with the OpenID Connect Authenticator v2.0.1. As the authenticator is fairly used today, it could be useful to try to find a solution.

@oanalavinia
Copy link

oanalavinia commented Aug 1, 2023 •
edited
Loading

Not an easy fix unfortunately
This dependency (microsoft azure java library) brings a transitive dependency with a fixed version range [1.3.3,2.4.7]. But OIDC has the version 2.4.11 defined since the last upgrade (it was upgraded to use 14.10 as the minimal parent)
The problem is that this ADAL library was archived this month and we already have the last version. So we have to migrate to MSAL4J in order to fix the problem. (upgrade + moving code from groovy, refactoring probably)
A quick fix for now should be to use a lower OIDC version ( <= 1.37.4 )
Testing also if excluding the dependency from maven brings problems

@oanalavinia oanalavinia changed the title The Office365 application cannot be installed on XWiki 14.10.13 The Office365 application cannot be installed with OpenID Connect version > 2.0.0 Aug 2, 2023
oanalavinia added a commit that referenced this issue Aug 2, 2023
@oanalavinia
The Office365 application cannot be installed with OpenID Connect ver…
3da490e 
…sion > 2.0.0 #25

* Exclude json-smart because the declared range is lower than the one managed by oidc authenticator
oanalavinia added a commit that referenced this issue Aug 3, 2023
@oanalavinia
Revert "The Office365 application cannot be installed with OpenID Con…
57df74c 
…nect version > 2.0.0 #25"

This reverts commit 3da490e.
This was done since this commit does not fixes the problem completely and a more complete PR will be created
@oanalavinia oanalavinia mentioned this issue Aug 3, 2023
Open
oanalavinia added a commit that referenced this issue Aug 3, 2023
@oanalavinia
The Office365 application cannot be installed with OpenID Connect ver…
dd6f080 
…sion > 2.0.0 #25

* exclude json-smart because the declared range is lower than the one managed by oidc authenticator and use a compatible version
* manage some transitive dependencies versions conflicts
@mflorea mflorea mentioned this issue Aug 3, 2023
Merged
oanalavinia added a commit that referenced this issue Aug 4, 2023
@oanalavinia
The Office365 application cannot be installed with OpenID Connect ver…
4f92717 
…sion > 2.0.0 #25

* add dependencyManagement for versions and exclusions
* remove the asm dep since it's not actually used by who declares it
oanalavinia added a commit that referenced this issue Aug 4, 2023
@oanalavinia
The Office365 application cannot be installed with OpenID Connect ver…
e1bd7ab 
…sion > 2.0.0 #25 (#27)

* exclude json-smart because the declared range is lower than the one managed by oidc authenticator and use a compatible version
* manage some transitive dependencies versions conflicts (the asm dep it's not actually used by who declares it)
@oanalavinia oanalavinia self-assigned this Aug 4, 2023
@oanalavinia oanalavinia added this to the 1.11.1 milestone Aug 4, 2023
@oanalavinia oanalavinia mentioned this issue Feb 29, 2024
Closed
@oanalavinia oanalavinia linked a pull request Mar 1, 2024 that will close this issue
The Office365 application cannot be installed with OpenID Connect version > 2.0.0 #25 #27
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oanalavinia oanalavinia

Labels
Priority: Major Type: Bug
Projects
None yet
Milestone
1.11.1
2 participants
@aubincleme @oanalavinia