Cannot update OnlyOffice Connector Application 2.4.0 on XWiki 16.10.2

[ClemensRobbenhaar]

When trying to update via the extension manager from Version 2.3.1, the install plan failed with the error message:

 
There is already a core extension covering feature [org.xwiki.contrib:xwiki-contrib-websocket]
class org.xwiki.extension.InstallException: Failed to resolve extension
    at org.xwiki.extension.job.internal.AbstractInstallPlanJob.installExtension(AbstractInstallPlanJob.java:913)
    at org.xwiki.extension.job.internal.AbstractInstallPlanJob.installExtension(AbstractInstallPlanJob.java:365)
    at org.xwiki.extension.job.internal.AbstractInstallPlanJob.installExtension(AbstractInstallPlanJob.java:333)
    at org.xwiki.extension.job.internal.AbstractInstallPlanJob.start(AbstractInstallPlanJob.java:304)
    at org.xwiki.extension.job.internal.InstallPlanJob.runInternal(InstallPlanJob.java:74)
    at org.xwiki.job.AbstractJob.runInContext(AbstractJob.java:246)
    at org.xwiki.job.AbstractJob.run(AbstractJob.java:223)
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
    at java.base/java.lang.Thread.run(Thread.java:840)
Caused by: class org.xwiki.extension.InstallException: Failed to create an install plan for extension dependency [com.xwiki.onlyoffice-connector:application-onlyoffice-connector-api-2.4.0]
    at org.xwiki.extension.job.internal.AbstractInstallPlanJob.installExtensionDependency(AbstractInstallPlanJob.java:805)
    at org.xwiki.extension.job.internal.AbstractInstallPlanJob.installMandatoryExtensionDependency(AbstractInstallPlanJob.java:755)
    at org.xwiki.extension.job.internal.AbstractInstallPlanJob.installExtensionDependency(AbstractInstallPlanJob.java:608)
    at org.xwiki.extension.job.internal.AbstractInstallPlanJob.installExtensionDependencies(AbstractInstallPlanJob.java:1201)
    at org.xwiki.extension.job.internal.AbstractInstallPlanJob.installExtension(AbstractInstallPlanJob.java:1121)
    at org.xwiki.extension.job.internal.AbstractInstallPlanJob.installExtension(AbstractInstallPlanJob.java:910)
    at org.xwiki.extension.job.internal.AbstractInstallPlanJob.installExtension(AbstractInstallPlanJob.java:365)
    at org.xwiki.extension.job.internal.AbstractInstallPlanJob.installExtension(AbstractInstallPlanJob.java:333)
    at org.xwiki.extension.job.internal.AbstractInstallPlanJob.start(AbstractInstallPlanJob.java:304)
    at org.xwiki.extension.job.internal.InstallPlanJob.runInternal(InstallPlanJob.java:74)
    at org.xwiki.job.AbstractJob.runInContext(AbstractJob.java:246)
    at org.xwiki.job.AbstractJob.run(AbstractJob.java:223)
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
    at java.base/java.lang.Thread.run(Thread.java:840)
Caused by: class org.xwiki.extension.InstallException: There is already a core extension covering feature [org.xwiki.contrib:xwiki-contrib-websocket]
    at org.xwiki.extension.job.internal.AbstractInstallPlanJob.checkCoreExtension(AbstractInstallPlanJob.java:1293)
    at org.xwiki.extension.job.internal.AbstractInstallPlanJob.checkCoreExtension(AbstractInstallPlanJob.java:1285)
    at org.xwiki.extension.job.internal.AbstractInstallPlanJob.installExtension(AbstractInstallPlanJob.java:1063)
    at org.xwiki.extension.job.internal.AbstractInstallPlanJob.installExtensionDependency(AbstractInstallPlanJob.java:801)
    at org.xwiki.extension.job.internal.AbstractInstallPlanJob.installMandatoryExtensionDependency(AbstractInstallPlanJob.java:755)
    at org.xwiki.extension.job.internal.AbstractInstallPlanJob.installExtensionDependency(AbstractInstallPlanJob.java:608)
    at org.xwiki.extension.job.internal.AbstractInstallPlanJob.installExtensionDependencies(AbstractInstallPlanJob.java:1201)
    at org.xwiki.extension.job.internal.AbstractInstallPlanJob.installExtension(AbstractInstallPlanJob.java:1121)
    at org.xwiki.extension.job.internal.AbstractInstallPlanJob.installExtension(AbstractInstallPlanJob.java:910)
    at org.xwiki.extension.job.internal.AbstractInstallPlanJob.installExtension(AbstractInstallPlanJob.java:365)
    at org.xwiki.extension.job.internal.AbstractInstallPlanJob.installExtension(AbstractInstallPlanJob.java:333)
    at org.xwiki.extension.job.internal.AbstractInstallPlanJob.start(AbstractInstallPlanJob.java:304)
    at org.xwiki.extension.job.internal.InstallPlanJob.runInternal(InstallPlanJob.java:74)
    at org.xwiki.job.AbstractJob.runInContext(AbstractJob.java:246)
    at org.xwiki.job.AbstractJob.run(AbstractJob.java:223)
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
    at java.base/java.lang.Thread.run(Thread.java:840)

I have seen the same issue on another installation, so I guess it is not just me.
However feel free to close the issue if you cannot reproduce it.

[oanat]

I have reproduced this issue on XWiki 16.4.6 with the latest version of OnlyOffice connector available in EM 2.4.0

[oanalavinia]

This is caused by xwiki/xwiki-platform@aa181b9 (which doesn't have a related jira ticket), so note that it is happening only for XWiki >= 16.9, 16.4.5, 15.10.13

[oanalavinia]

Investigation:
This is related to the changes needed for #44, namely having the api module as a feature for the contrib app so the module is automatically uninstalled. Now the xwiki websocket module does the same 'trick'. So you cannot install the onllyoffice api module because org.xwiki.contrib:xwiki-contrib-websocket is already provided. This happens in newer xwiki versions (the change was done in a misc commit, I need to check which versions, but I guess XWiki >=16.9, 16.4.5, 15.10.13)
It is too soon to remove the xwiki.extension.features property from the onlyoffice api module, so the fix was to create a different module which will hold the feature property. api will depend on it, but it will be optional. This way, when you install on a newer xwiki version, EM can bypass this dependency

Note:
The application-onlyoffice-connector-websocket module should be removed in order to simply use the xwiki-platform-websocket dependency once enough time has passed (~1year), in order to leave clients time to update to a onlyoffice version with the fix. This trick was needed only to be able to remove a deprecated contrib dependency, once that is done, we can depend direclty on the platform module.

[oanalavinia]

An use case to test the problem and related issues (e.g. #44):

1. Install OnlyOffice 2.2.0 and try to edit an office file - this works
2. Upgrade to 2.3.0 / 2.3.1 and try to edit an office file - you cannot use realtime editing, just 'plain' edit; you get notified about this
3. Upgrade to 2.4.0 - you cannot upgrade to this version / install it directly on recent XWiki versions (XWiki >=16.9, 16.4.5, 15.10.13).