Task manager doesn't respect default date format

[lamblinc]

Steps to reproduce:

• In a brand new instance with default localization parameter
• Create a task
• Go to the task manager

Expected result: the deadline colum display the date in the same format as the default setting for date (for example the one for page creation at the bottom of the page is YYYY/MM/DD hh:mm

Actual result: the date is in DD/MM/YYY hh:mm format

Possibilities:

• Make the task manager respect the localization setting
  Or
• Add an option to set the date display format

[snazare]

there are more issues here:

I. if date macro date storage format is changed, it also breaks the date of existing tasks.

steps to reproduce:

1. make sure the date macro administration does not have any format set
2. create a task inline and add a date
3. go to administration - other - date macro and set a new display format -> works as expected, the date is displayed correctly in inline tasks
4. go to administration - other - date macro and set a new storage format
5. check the created task -> date from inline macros breaks and the message "Failed to execute the [date] macro. Cause: [Failed to parse the given date, expected format [yyyy-MM-ddHH:mm]!]. Click on this message for details." is displayed -> should we remove the option to change the storage format?

II. if the date in localization preferences is changed, inline tasks also break.

steps to reproduce:

1. make sure the date macro administration and the localization administration does not have any format set
2. create a task inline and add a date
3. go to administration - content - localization and set a new date format (e.g. dd-MM-yyyy HH:mm instead of the default yyyy-MM-dd HH:mm)
4. check the created task -> date from inline macros breaks and the message "Failed to execute the [date] macro. Cause: [Failed to parse the given date, expected format [yyyy-MM-ddHH:mm]!]. Click on this message for details." is displayed -> the date of tasks should respect the display format set in localization preferences, if nothing is defined in the Date Macro configuration. If a format is defined in Date Macro configuration, the date macro used within the tasks should respect that defined date, even if a date format is specified in localization preferences.

[trrenty]

The storageDateFormat property affects the way the different date properties are expected to be stored in the task macro, namely: completeDate, createDate and the value of the date macro (that is used as the deadline).

Currently, the value of the storage format is retrieved from the following sources, in this exact order: Date Macro admin section -> xwiki.properties -> XWiki Preferences -> "yyyy/MM/dd HH:mm".

The storage format option was meant to offer some flexibility to users that did not use the wysiwyg editor. Allowing them to use shorter formats when creating task macros.

The parameters completeDate, createDate of the task macro and value of the date macro are stored using the storageDateFormat. When the macro is being rendered, it expects the aforementioned parameters to have the currently set format. When changing the storageDateFormat, the existing task and date macros do not follow the format anymore and will not display correctly. The macros created from this moment onward will have the date parameters set correctly.

Since the date format in the Wiki Preferences is used only for displaying purposes, we shouldn't rely on it in the Task Application. Thus, we can skip this step and have the following lookup chain Date Macro admin section -> xwiki.properties -> "yyyy/MM/dd HH:mm"

Possible problems:

For the users that installed xwiki -> changed the xwiki date format -> installed and used task manager, the task and date macro will display this error

Failed to execute the [date] macro. Cause: [Failed to parse the given date, expected format [yyyy-MM-ddHH:mm]!]

In order to fix it, the admin should go to the Date Macro administration section and fill the The format that will be used to store dates used in Task Manager. field with the value of the date format in Content > Localization > Date Format.

[trrenty]

Additionally to ignoring the localization setting from the xwiki instance, I also added some hints to the administration section, in order to make the properties more clear.

[lamblinc]

Will it be part of 3.7?