Errors in EM logs when upgrading the Task manager

[ane-gabriela]

Preconditions: Have an older version of Task Manager Application (Pro) installed. In this case 3.6.6 was used.

Steps to reproduce:

1. Click on Administer Wiki > Extensions
2. Upgrade Task Manager Application (Pro) (in this case to 3.7.0-rc-1)
3. Check the Install log

Expected results: The application was upgraded with no errors in the logs.

Actual results:

com.xwiki.task.TaskStatuses class java.lang.ClassNotFoundException: com.xwiki.task.TaskStatuses at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:445) at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:592) at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:525) at org.xwiki.classloader.xwiki.internal.ContextNamespaceURLClassLoader.loadClass(ContextNamespaceURLClassLoader.java:176) at java.base/java.lang.Class.forName0(Native Method) at java.base/java.lang.Class.forName(Class.java:467) at org.xwiki.component.util.ReflectionUtils.unserializeType(ReflectionUtils.java:548) at org.xwiki.rendering.wikimacro.internal.DefaultWikiMacroFactory.buildParameterDescriptors(DefaultWikiMacroFactory.java:302) at org.xwiki.rendering.wikimacro.internal.DefaultWikiMacroFactory.buildMacro(DefaultWikiMacroFactory.java:171) at org.xwiki.rendering.wikimacro.internal.DefaultWikiMacroFactory.createWikiMacro(DefaultWikiMacroFactory.java:114) at org.xwiki.rendering.internal.macro.wikibridge.WikiMacroEventListener.registerMacro(WikiMacroEventListener.java:124) at org.xwiki.rendering.internal.macro.wikibridge.WikiMacroEventListener.onEvent(WikiMacroEventListener.java:105) at org.xwiki.observation.internal.DefaultObservationManager.notify(DefaultObservationManager.java:338) at org.xwiki.observation.internal.DefaultObservationManager.notify(DefaultObservationManager.java:303) at com.xpn.xwiki.XWiki.afterSave(XWiki.java:2036) at com.xpn.xwiki.XWiki.saveDocument(XWiki.java:2124) at org.xwiki.extension.xar.internal.handler.packager.DocumentMergeImporter.saveDocumentSetContextUser(DocumentMergeImporter.java:208) at org.xwiki.extension.xar.internal.handler.packager.DocumentMergeImporter.saveDocument(DocumentMergeImporter.java:154) at org.xwiki.extension.xar.internal.handler.packager.DocumentMergeImporter.importDocument(DocumentMergeImporter.java:117) at org.xwiki.extension.xar.internal.handler.packager.Packager.importDocumentToWiki(Packager.java:230) at org.xwiki.extension.xar.internal.handler.packager.Packager.importXARToWiki(Packager.java:184) at org.xwiki.extension.xar.internal.handler.packager.Packager.importXARToWiki(Packager.java:157) at org.xwiki.extension.xar.internal.handler.packager.Packager.importXAR(Packager.java:148) at org.xwiki.extension.xar.internal.handler.XarExtensionHandler.installInternal(XarExtensionHandler.java:189) at org.xwiki.extension.xar.internal.handler.XarExtensionHandler.upgrade(XarExtensionHandler.java:169) at org.xwiki.extension.handler.internal.DefaultExtensionHandlerManager.upgrade(DefaultExtensionHandlerManager.java:139) at org.xwiki.extension.job.internal.AbstractExtensionJob.installExtension(AbstractExtensionJob.java:349) at org.xwiki.extension.job.internal.AbstractExtensionJob.applyAction(AbstractExtensionJob.java:233) at org.xwiki.extension.job.internal.AbstractExtensionJob.applyActions(AbstractExtensionJob.java:181) at org.xwiki.extension.job.internal.InstallJob.runInternal(InstallJob.java:140) at org.xwiki.job.AbstractJob.runInContext(AbstractJob.java:246) at org.xwiki.job.AbstractJob.run(AbstractJob.java:223) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) at java.base/java.lang.Thread.run(Thread.java:840)

NOTE: This error makes the statuses "To Do / In Progress / Done" not appear in Status filter parameter, when adding a Task macro.
This issue seems to be resolved after a wiki restart.

Environment: Windows 11 Pro, https://proapps.cloud.xwiki.com/ - XWiki 16.4.3, Chrome 134, Task Manager Application (Pro)
3.7.0-rc-1

[trrenty]

The issue was caused by the following:

• api module defined a new interface TaskStatuses in order to identify a picker for task report macro
• upgrading from 3.6.x to 3.7.x would trigger the re-registration of the task report macro (wiki page macro)
• using reflection, the type of the status field is getting resolved and fails. probably due to the fact that the api module was not installed yet or the DefaultWikiMacroFactory didn't use the updated class loader or something similar.

In order to fix this, I used a different type for the status field that is bound to exist during an upgrade.