Skip to content

Author of task macro is not properly recorded #266

Description

@KebabRonin

Describe the bug
A clear and concise description of what the bug is.

Steps to reproduce
Steps to reproduce the problematic behavior:

  1. In a page like Sandbox, create a task macro
  2. Check it with User A
  3. Uncheck it with User B

Expected behavior
The history shows that each change was performed by the respective user.

Actual behavior
In the history section, both the page with the task macro and the associated task page appear to be edited by User A twice.
Also, when creating the associated task page, the page is created by XWikiGuest.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

  • OS: linux mint
  • Browser firefox
  • XWiki version 14.10, 16.10.5, 16.10.9
  • App version 3.9.0, 3.0

Additional context
Looking through the code, it might be from the platform not using the context, but the last author (maybe it expects the document to already be saved?)
https://github.com/xwiki/xwiki-platform/blob/edf81b8e9c7fb4dcd0cb8def92f7a5fd27e91e2e/xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/XWikiHibernateStore.java#L642

These lines should be added in TaskManager code I think:
https://github.com/xwiki/xwiki-platform/blob/edf81b8e9c7fb4dcd0cb8def92f7a5fd27e91e2e/xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/api/Document.java#L2886C1-L2888C75

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions