Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with votes while changing the options multiple/single #57

Closed
ane-gabriela opened this issue Oct 28, 2019 · 1 comment
Assignees
Milestone

Comments

@ane-gabriela
Copy link

@ane-gabriela ane-gabriela commented Oct 28, 2019

With ticket #41 the option to change from single/multiple and vice-versa was introduced.

This new functionality causes an issue while changing the options.

Steps to reproduce:

  1. Create a new poll with multiple choices, Status > Active
  2. Vote with multiple users
  3. Edit the poll and change Type > Can select a single option
  4. Save the changes and observe the results

Expected results: Ticket #41 doesn't have any info about how should the votes be saved when changing the option. In this case, a documentation needs to be put in place of what happens when there are multiple selections and the user changes them to single.

Also, need to establish:

  1. Can the user change the option in any Status of the poll (In preparation/Active/Finished) ?
  2. Can the option be changed any number of times?
  3. Should simple user be able to change the option?

At the moment the simple users can do all 3 points.

Actual results: The votes are saved randomly, not even the last selections. Once the poll is changed to single option the total number of votes remain as per Multiple selection.

Environment: XWiki 9.11 Standard with Chrome 77, Polls Application (Pro) 2.0

Step1

Step2

Step3

Step4

@silviamacovei

This comment has been minimized.

Copy link

@silviamacovei silviamacovei commented Oct 28, 2019

IMO

  1. The user should be able to change the option if the Polls are “In preparation”
  2. While the poll is in prep, the poll creator should be able to change her mind any number of times
  3. The poll creator and admins should be able to change the option.
@acotiuga acotiuga self-assigned this Nov 12, 2019
@acotiuga acotiuga added this to the 2.0.1 milestone Nov 12, 2019
acotiuga added a commit that referenced this issue Nov 12, 2019
* allow the type update only if the poll is still in preparation phase
* only the poll's creator or an wiki admin should be able to update it
@acotiuga acotiuga closed this Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.