Skip to content

Add warning when adding macros without a license #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
oanalavinia opened this issue Feb 20, 2023 · 1 comment · Fixed by #111
Closed

Add warning when adding macros without a license #110

oanalavinia opened this issue Feb 20, 2023 · 1 comment · Fixed by #111
Assignees
@oanalavinia
Labels
Priority: Major Type: Bug
Milestone
1.7.1

Comments

@oanalavinia
Copy link
Contributor

oanalavinia commented Feb 20, 2023 •
edited
Loading

Since macros are registered independently of an existing license, these can be added to a page even if the license does not yet exists. The macros are not fully functional in this case, because Licensing removes the view right on the macro page.

A message should be displayed to users. This should be done at the code level of each macro.
@oanalavinia
Copy link
Contributor Author

Example https://github.com/xwikisas/application-diagram/blob/master/application-diagram-ui/src/main/resources/Diagram/DiagramMacro.xml#L327

oanalavinia added a commit to oanalavinia/xwiki-pro-macros that referenced this issue Feb 20, 2023
@oanalavinia
Add warning when adding macros without a license xwikisas#110
2dc359e 
* add error for the XWiki.Macros space
@oanalavinia oanalavinia linked a pull request Feb 20, 2023 that will close this issue
Add warning when adding macros without a license #110 #111
Merged
oanalavinia added a commit to oanalavinia/xwiki-pro-macros that referenced this issue Feb 21, 2023
@oanalavinia
Add warning when adding macros without a license xwikisas#110
cbb0e29 
* add license error for the macros in the Confluence.Macros space
oanalavinia added a commit to oanalavinia/xwiki-pro-macros that referenced this issue Feb 21, 2023
@oanalavinia
Add warning when adding macros without a license xwikisas#110
62249c8 
* forgot to define parameters for attachments macro
oanalavinia added a commit that referenced this issue Feb 21, 2023
@oanalavinia
Add warning when adding macros without a license #110 (#111)
3bc7d44 
* add license error for the macros defined in the XWiki.Macros and Confluence.Macros spaces
* move the code inside a executeMacro macro and call it only when there is a valid license
@oanalavinia oanalavinia added this to the 1.7.1 milestone Feb 21, 2023
@oanalavinia oanalavinia self-assigned this May 5, 2023
@oanalavinia oanalavinia mentioned this issue May 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oanalavinia oanalavinia

Labels
Priority: Major Type: Bug
Projects
None yet
Milestone
1.7.1
Development

Successfully merging a pull request may close this issue.

Add warning when adding macros without a license #110 oanalavinia/xwiki-pro-macros
1 participant
@oanalavinia