Skip to content

[Regression] It's not possible to upload new files with the attachments macro anymore #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lucaa opened this issue May 12, 2023 · 1 comment · Fixed by #159
Closed

[Regression] It's not possible to upload new files with the attachments macro anymore #132

lucaa opened this issue May 12, 2023 · 1 comment · Fixed by #159
Assignees
@oanalavinia
Labels
Macro: Attachments Priority: Major
Milestone
1.10

Comments

@lucaa
Copy link

lucaa commented May 12, 2023 •
edited
Loading

Starting with Pro macros 1.8, the attachments macro does not have the option to allow upload of new files anymore, as it did on version 1.6.

The upload also used to be enabled by default. Now the parameter does not even exist anymore.
@lucaa
Copy link
Author

lucaa commented May 12, 2023 •
edited
Loading

This change was made as part of the work of compatibility with recent versions done for ticket #112, see the comment for PR #123 .

@oanat oanat mentioned this issue Jun 29, 2023
Closed
@snazare snazare assigned oanalavinia and unassigned clemdee Aug 9, 2023
oanalavinia added a commit to oanalavinia/xwiki-pro-macros that referenced this issue Aug 10, 2023
@oanalavinia
[Regression] It's not possible to upload new files with the attachmen…
33f4c83 
…ts macro anymore xwikisas#132

* add back the upload parameter
* use XWiki.FileUploader for a file input and refresh livedata on upload finished
* TODO: test on 13.10, check for livetable
oanalavinia added a commit to oanalavinia/xwiki-pro-macros that referenced this issue Aug 11, 2023
@oanalavinia
[Regression] It's not possible to upload new files with the attachmen…
8b04d2b 
…ts macro anymore xwikisas#132

* export from 13.10
* add back upload parameter description
* this code might need some adjustments after xwikisas#131 will be fixed
oanalavinia added a commit to oanalavinia/xwiki-pro-macros that referenced this issue Aug 21, 2023
@oanalavinia
[Regression] It's not possible to upload new files with the attachmen…
39750a0 
…ts macro anymore xwikisas#132

* make sure that XWiki.FileUpload is loaded
oanalavinia added a commit to oanalavinia/xwiki-pro-macros that referenced this issue Sep 13, 2023
@oanalavinia
[Regression] It's not possible to upload new files with the attachmen…
74104fb 
…ts macro anymore xwikisas#132

* don't refresh livedata if the upload event does not come a confluence attachments button
oanalavinia added a commit that referenced this issue Sep 27, 2023
@oanalavinia
[Regression] It's not possible to upload new files with the attachmen…
1e3e3a4 
…ts macro anymore #132 (#159)

* add back the upload parameter with description
* use XWiki.FileUploader for a file input and refresh livedata on upload finished
* don't refresh livedata if the upload event does not come a confluence attachments button
* this code might need some adjustments after #131 will be fixed
@oanalavinia oanalavinia modified the milestones: 1.9.4, 1.10 Sep 27, 2023
@oanalavinia oanalavinia linked a pull request Sep 27, 2023 that will close this issue
[Regression] It's not possible to upload new files with the attachments macro anymore #132 #159
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oanalavinia oanalavinia

Labels
Macro: Attachments Priority: Major
Projects
None yet
Milestone
1.10
4 participants
@lucaa @oanalavinia @snazare @clemdee