Skip to content

The "Show more" button of the Recently Updated macro does nothing after editing #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ane-gabriela opened this issue Jun 8, 2023 · 2 comments

Comments

@ane-gabriela
Copy link

ane-gabriela commented Jun 8, 2023

Steps to reproduce:

  1. Edit a page
  2. Click on Insert > Other macros
  3. Search and select Recently Updated
  4. Select a smaller Max ex. 5 (maximum number of results to be displayed)
  5. Submit
  6. Save & View
  7. Click on "Show more"
    ShowMore

Expected results: The other results appear.

Actual results: Nothing happens when clicking the "Show more" option.

NOTE: Once the page is refreshed the "Show more" option is functional and the results appear.

Environment: Windows 11, XWiki 14.10.10 with MySQL 8.0 and Chrome 114, Pro Macros 1.9

@mflorea
Copy link
Contributor

mflorea commented Jul 26, 2023

The click listener for the Show More button needs to be registered also when the xwiki:dom:updated event is triggered (which happens when the in-place editor saves the content, without reloading the page).

@snazare snazare assigned raphj and unassigned snazare Oct 3, 2023
@raphj raphj changed the title Recently Updated macro: The "Show more" option isn't working after saving the page The "Show more" button of the Recently Updated macro does nothing after editing Oct 3, 2023
raphj added a commit that referenced this issue Oct 3, 2023
@raphj raphj assigned raphj and snazare and unassigned raphj Oct 3, 2023
@raphj
Copy link
Contributor

raphj commented Oct 3, 2023

Fixed @snazare

@oanalavinia oanalavinia added this to the 1.10 milestone Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants