Skip to content

Recently Updated macro: improvements to layout #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ane-gabriela opened this issue Jun 12, 2023 · 0 comments
Closed

Recently Updated macro: improvements to layout #148

ane-gabriela opened this issue Jun 12, 2023 · 0 comments
Assignees
@raphj
Labels
Macro: Recently Updated Type: Improvement
Milestone
1.12

Comments

@ane-gabriela
Copy link

ane-gabriela commented Jun 12, 2023 •
edited by raphj
Loading

Preconditions: Have a page with the Recently Updated Macro added with default selections.

Steps to reproduce:

  1. Edit the page with the Recently Updated Macro
  2. Select ShowProfilePic
  3. Submit
  4. Save & View the page
  5. Edit again
  6. Under Theme add "social" to group by user
  7. Submit
  8. Save & View

Actual results:

  1. The Profile Pic should have the same dimensions for all users.
  2. In case of the social grouping the spacing between the results isn't consistent - some are narrow.

ProfilePics

Layout

Environment: Windows 11, XWiki 14.10.10 with MySQL 8.0 and Chrome 114, Pro Macros 1.9
raphj added a commit that referenced this issue Oct 23, 2023
@raphj
#148 Recently Updated macro: improvements to layout
ff4de34 
* Some images don't have the avatar class. This commit fixes  the CSS selector to target all avatars so
  They are hidden the same way and have the same size.
raphj added a commit that referenced this issue Oct 23, 2023
@raphj
#148 Recently Updated macro: improvements to layout
2ed9a25 
* Normalize the last author so results are correctly collapsed in the social grouping theme
@raphj raphj assigned raphj and unassigned snazare Oct 23, 2023
@oanalavinia oanalavinia added this to the 1.12 milestone Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raphj raphj

Labels
Macro: Recently Updated Type: Improvement
Projects
No open projects
ProAppsRoadmapOct-Dec2023
Status: Done
Milestone
1.12
Development

No branches or pull requests
4 participants
@raphj @oanalavinia @snazare @ane-gabriela