Skip to content

The Recently Updated Macro shows hidden pages #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ane-gabriela opened this issue Jun 12, 2023 · 2 comments
Closed

The Recently Updated Macro shows hidden pages #149

ane-gabriela opened this issue Jun 12, 2023 · 2 comments
Assignees
@snazare
Labels
Macro: Recently Updated Type: Bug
Milestone
1.10

Comments

@ane-gabriela
Copy link

Steps to reproduce:

  1. As Admin add the Recently Updated Macro in a page
  2. Select Spaces "*" > Submit (to show pages from all wikis)
  3. Save & View
  4. Create a new subwiki
  5. Access the page with the Recently Updated Macro again with a simple user (no added rights)

Expected results: Hidden pages aren't shown in the results.

Actual results: Hidden/technical pages appear and cand be accessed even with unregistered users.

HiddenPages

HiddenPage

Environment: Windows 11, XWiki 14.10.10 with MySQL 8.0 and Chrome 114, Pro Macros 1.9
@snazare snazare assigned raphj and unassigned snazare Oct 3, 2023
@raphj raphj changed the title Recently Updated Macro: Hidden pages appear shown in the results The Recently Updated Macro shows hidden pages Oct 3, 2023
raphj added a commit that referenced this issue Oct 3, 2023
@raphj
#149 The Recently Updated Macro shows hidden pages
6ad08f7
@raphj
Copy link
Contributor

raphj commented Oct 3, 2023

Fixed, now the macro only shows hidden pages if the user prefers displaying hidden pages @snazare

@raphj raphj assigned snazare and unassigned raphj Oct 3, 2023
raphj added a commit that referenced this issue Oct 4, 2023
@raphj
#149 The Recently Updated Macro shows hidden pages
fdea126 
* Also hide comments and attachments that are on an hidden page.
@raphj
Copy link
Contributor

raphj commented Oct 4, 2023

During the night, it occurred to me we should also hide comments and attachments that are in an hidden page, so I committed this as well.

@oanalavinia oanalavinia added this to the 1.10 milestone Oct 11, 2023
This was referenced Oct 20, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snazare snazare

Labels
Macro: Recently Updated Type: Bug
Projects
None yet
Milestone
1.10
Development

No branches or pull requests
4 participants
@raphj @oanalavinia @snazare @ane-gabriela