Unused att--filename parameter in Layout cell macro

[petrenkonikita112263]

Prerequisites:

• XWiki instance 13.10
• Latest version of Pro Macros
• Trial license
• Having at least one attachment (any type) on a test page

Step to reproduce:

1. Go into Test Page, start editing it via Wiki mode.
2. Copy/paste this line of code. Don't forget to replace filename with the existing one on your page.

{{layout-cell att--filename="image.jpg"}}
Lorem Ipsum is simply dummy text of the printing and typesetting industry.
{{/layout-cell}}

3. Save it.

Actual result
Despite of specified attachment, only text in a cell will be visible.

Expected result
I see that field att--filename was introduced in commit 5ef0116 in LayoutCell.xml file. I don't know what was the intention of it to display image/player/viewer in a cell, but if it has no effect, it can be removed other macros of Layout don't use it. That's why only content of macro shall be as input for this macro

[petrenkonikita112263]

From my last paragraph, instead of looking at this as bug, it can be a slight improvement by removing valueless field "att--filename" with further renaming the title (and label) of this issue.

[raphj]

I removed the unused parameter. I haven't found a way to use this parameter in Confluence. I suspect it comes from a copy paste that was not completely cleaned up. We can always properly implement the parameter later if it indeed exists. FYI @acotiuga.