Recently updated macro gives out XWikiDateTool error in the logs

[LucianCheve]

THIS ISSUE WAS REPRODUCED WITH AN EXPORT OF A WIKI PAGE THAT WAS MIGRATED FROM CONFLUENCE.

Reproduced on XWiki 15.10.7 having the following extensions installed:

• Confluence Migrator Pro 1.12.0
• Task Manager Pro 3.4.0
• Pro Macros 1.16.1

On XWiki 14.10.18, with the same extensions and the same versions, I did not reproduce the error.

Steps to reproduce:

1. Have an XWiki version 15.10.7 with the following extensions installed:

• Confluence Migrator Pro 1.12.0
• Task Manager Pro 3.4.0
• Pro Macros 1.16.1

2. Have an XWiki page migrated from Confluence that contains the "recently-updated" macro
3. Access the page

Expected results:
The server logs don't show any errors.

Actual result:
Each time the page is accessed, the logs show the following error:
2024-03-26 13:44:33,576 [qtp1413246829-114 - http://192.168.150.173:8080/xwiki/bin/view/MathSeminarWiki/] ERROR o.a.v.rendering - Left side ($datetool.difference($mostRecentDate, $date).getMilliseconds()) of comparison operation has null value at xwiki:MathSeminarWiki.WebHome[line 206, column 98]

Link to where the error is pointing to:

xwiki-pro-macros/xwiki-pro-macros-ui/src/main/resources/Confluence/Macros/RecentlyUpdatedService.xml

Line 245 in 2e482d0

#if ($mostRecentDate == $NULL || $datetool.difference($mostRecentDate, $date).getMilliseconds() > 0)

[raphj]

Hi @LucianCheve,

I could not reproduce but I added some defensive programming to make the warning go away. Can you test with version 1.16.4, which I'm releasing right now?

[LucianCheve]

Hello, @raphj

Using the same XAR file as before, I reproduced the error on 15.10.7 using Pro Macros 1.16.1 (the same conditions when I created the ticket)
Then, I upgraded Pro Macros to 1.16.4 and I still got the same error in the logs.

On XWiki 15.10.5, using the old version of Pro Macros, 1.16.1, I do not get the error in the logs. I upgraded to 1.16.4, but I was not expecting anything strange to happen, and it did not.

I will try on 15.10.8 and 16.2.0 to see if I reproduce

[LucianCheve]

Reproduced on 15.10.8. using Pro Macros 1.16.1. After, I upgraded Pro Macros to version 1.16.4 and I still got the errors in the logs.

Using the same XAR file, with Pro Macros 1.16.1 and XWiki 16.2.0, I did not reproduce the error. Nothing shows up in the logs.