Recently Updated macro cannot be inserted in the WYSIWYG editor

[ane-gabriela]

(edit by @raphj: Original title: Recently Updated macro disappears when adding Author)

Seems that issue #147 is still reproducing for me.

Preconditions: Have a page with the Recently Updated Macro added with Spaces set to @global or @ALL.

Steps to reproduce:

1. Edit the page with the Recently Updated Macro
2. Select a Author (Filter the results by author) ex. GabrielaAnechitoaei (in this example there were many pages created and edited with this user)
   
3. Submit

Expected results: The pages that were updated by the selected user appear.

Actual results: The macro just disappears completely from the page.

Environment: Windows 11, XWiki Cloud 15.10.8, Chrome 123, Pro Macros 1.16.5

[petrenkonikita112263]

I can also reproduce issue on same XWiki with latest Pro Macros 1.17.

Prerequisite: you need at least several actions on your XWiki done before doing this (page creation or updated, comment or attachment added)

• Copy/paste this code on Test page

{{recently-updated spaces="@global" types="page, attachments" max="10" showProfilePic="true" hideHeading="true" theme="social"/}}

• Save it
• Try to edit macro in CKEditor and provide input into author field
• Click submit

Actual result: it removes entirly call of macro from XWiki page and result is blank space.

I only see another strange behavior, if I modify the above macro in Wiki mode with new syntax

{{recently-updated spaces="@global" types="page, attachments" max="10" theme="social" showProfilePic="true" hideHeading="true" author="XWiki.Admin"/}}

Then I see No more results

[michitux]

I wondered if this was an issue in xwiki-platform and so I debugged this a bit. The root cause of this is that this code overrides the $response variable in Velocity. This breaks the code that writes to the response in the HTML converter that is used by CKEditor as the Velocity context is shared.

[raphj]

Thanks @michitux for the investigation, not setting $response indeed fixes the issue.