Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop a Microsoft Stream macro #69

Closed
oanalavinia opened this issue Jun 23, 2022 · 1 comment · Fixed by #70
Closed

Develop a Microsoft Stream macro #69

oanalavinia opened this issue Jun 23, 2022 · 1 comment · Fixed by #70
Assignees
@oanalavinia
Labels
Macro: MS Stream Type: New Feature
Milestone
1.3

Comments

@oanalavinia
Copy link
Contributor

Provide a macro that would add the possibility to embed Microsoft Stream videos.

microsoftStreamEmbed

Similar to the options provided by Microsoft Stream when sharing a video (by embed, as seen in the above image), the macro will provide parameters for:

  • width
  • height
  • alignment
  • autoplay
  • show info
  • start at

The macro could also consider the compatibility with https://marketplace.atlassian.com/apps/1224419/microsoft-stream-for-confluence?tab=overview&hosting=cloud
@oanalavinia oanalavinia self-assigned this Jun 23, 2022
oanalavinia added a commit to oanalavinia/xwiki-pro-macros that referenced this issue Jun 23, 2022
@oanalavinia
Develop a Microsoft Stream macro xwikisas#69
60e603c 
* first version that process the video URL and the parameters, since values from macro have priority over values from the passed url
oanalavinia added a commit to oanalavinia/xwiki-pro-macros that referenced this issue Jun 24, 2022
@oanalavinia
Develop a Microsoft Stream macro xwikisas#69
d45d5a8 
* consider the queryParams value in case showinfo and autoplay are not defined
* small refactoring
oanalavinia added a commit to oanalavinia/xwiki-pro-macros that referenced this issue Jul 7, 2022
@oanalavinia
Develop a Microsoft Stream macro xwikisas#69
72658c2 
* code refactoring
* change macro name to the shorter version msStream
* replace deprecated methods #getSeconds()...
oanalavinia added a commit to oanalavinia/xwiki-pro-macros that referenced this issue Jul 7, 2022
@oanalavinia
Develop a Microsoft Stream macro xwikisas#69
75d1c60 
* refactor #getBaseURLAndQueryParams
* add syntaxId parameter for $services.rendering.escape method call and arrange code to not exceed the limit of 120 characters
oanalavinia added a commit to oanalavinia/xwiki-pro-macros that referenced this issue Jul 14, 2022
@oanalavinia
Develop a Microsoft Stream macro xwikisas#69
e293ee6 
* add a dropdown with accepted values for the alignment parameter
oanalavinia added a commit to oanalavinia/xwiki-pro-macros that referenced this issue Jul 18, 2022
@oanalavinia
Develop a Microsoft Stream macro xwikisas#69
fa6eebd 
* make the msStream macro a general one; a confluence bridge macro will be added after, with the corresponding name net-presago-stream-macro
oanalavinia added a commit to oanalavinia/xwiki-pro-macros that referenced this issue Jul 18, 2022
@oanalavinia
Develop a Microsoft Stream macro xwikisas#69
4790bbb 
* finish moving MicrosoftStream to XWiki.Macro space
* move macro translations to the correct page
* fix codestyle for AlignmentType
oanalavinia added a commit to oanalavinia/xwiki-pro-macros that referenced this issue Jul 19, 2022
@oanalavinia
Develop a Microsoft Stream macro xwikisas#69
a5fe799 
* forgot to add change for the stylesheet page
oanalavinia added a commit to oanalavinia/xwiki-pro-macros that referenced this issue Jul 22, 2022
@oanalavinia @mflorea
Develop a Microsoft Stream macro xwikisas#69
784dd9a 
* small update

Co-authored-by: Marius Dumitru Florea <marius@xwiki.com>
oanalavinia added a commit that referenced this issue Jul 22, 2022
@oanalavinia
Develop a Microsoft Stream macro #69 (#70)
72a8447 
* process the video URL and the parameters; consider that values from macro have priority over values from the passed url
* add a dropdown with accepted values for the alignment parameter
* make the msStream macro a general one; a confluence bridge macro will be added after, with the corresponding name net-presago-stream-macro
@oanalavinia oanalavinia linked a pull request Jul 22, 2022 that will close this issue
Develop a Microsoft Stream macro #69 #70
Merged
@oanalavinia
Copy link
Contributor Author

Note that the Confluence bridge macro was not added since the import will fail for now, due to https://jira.xwiki.org/browse/CONFLUENCE-105

@oanalavinia oanalavinia mentioned this issue Jul 22, 2022
Closed
@trrenty trrenty added this to the 1.3 milestone Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oanalavinia oanalavinia

Labels
Macro: MS Stream Type: New Feature
Projects
None yet
Milestone
1.3
Development

Successfully merging a pull request may close this issue.

Develop a Microsoft Stream macro #69 oanalavinia/xwiki-pro-macros
2 participants
@oanalavinia @trrenty