Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagram is empty after conversion from drawio #99

Closed
snazare opened this issue Nov 17, 2022 · 2 comments
Closed

Diagram is empty after conversion from drawio #99

snazare opened this issue Nov 17, 2022 · 2 comments

Comments

@snazare
Copy link
Contributor

snazare commented Nov 17, 2022

  1. Import a page containing a drawio diagram from confluence
  2. Find the imported page in XWiki
  3. Click on convert to diagram

Expected result: the drawio diagram is converted into an XWiki diagram and can be edited

Actual result: the drawio diagram is converted, but the page is empty

diagram-drawio.mp4

Environment: XWiki 14.4.6, cloud, Confluence Migrator 1.0.8, Pro Macros 1.6

@raphj
Copy link
Contributor

raphj commented Nov 17, 2022

For the record, it seems to be caused by the missing .drawio extension in the attachments. I copied this page, added the extensions and it worked. So something is not happy when the .drawio extension is not there.

The drawio macro itself seems to not care (after a grep on .drawio), and the diagram importer seem to not care neither since it runs regexes on the content instead of relying on extensions, at least in this file: https://github.com/xwikisas/application-diagram/blob/master/application-diagram-api/src/main/java/com/xwiki/diagram/internal/DiagramImporter.java (and I didn't find anything with grep on this repository neither)

@raphj
Copy link
Contributor

raphj commented Nov 17, 2022

The drawio bridge macro does not require any .drawio extension anymore. Thanks @oanalavinia for the investigation.

@snazare snazare added this to the 1.7 milestone Nov 26, 2022
@snazare snazare closed this as completed Nov 26, 2022
@oanalavinia oanalavinia modified the milestones: 1.7, 1.6.1 Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants