Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget Activities in Inactive Widgets area #283

Closed
desaiuditd opened this issue Feb 25, 2014 · 9 comments

Comments

Projects
None yet
4 participants
@desaiuditd
Copy link
Contributor

commented Feb 25, 2014

It seems that Stream is not able to log widget activities/changes from the Inactive Widgets area. Following two use cases are not being tracked down:

  • Widgets are sorted
  • A widget is updated

"Widget is deleted from Inactive Area" is already handled in #282

@shadyvb

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2014

@desaiuditd Nice catch! We definitely need to track updates to widgets wherever they may be.

However i'm not sure if we really need to track sorting of inactive widgets, doesn't make much sense to me. @fjarrett Thoughts ?

@westonruter

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2014

Yeah, probably no need to track sorting of inactive widgets. It's really just a trash area for widget instances.

@fjarrett

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2014

@shadyvb @westonruter Why not? I mean, it's a WordPress change so shouldn't Stream be tracking every single thing that is changed, be it big or small? With the changes coming in #251 people can easily opt-out of tracking whatever they think is unnecessary in their opinion.

Inactive widget order is not a user-specific order (like reordering metaboxes or something) it is an order that affects all users on that screen. Correct me if I'm wrong about this.

Maybe some more deep thought/discussion should be done about where exactly we draw the line for Stream, what it should track, and what it should not track.

@westonruter

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2014

Correct. Inactive widget order is not user-specific. All users would see the same.

@shadyvb

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2014

@fjarrett I do not think a user would be able to ignore this type of action, since he'd need to disable all Widgets::Order actions and lose updates to order operations in other sidebars as well.
My POV is that while we do strive to track almost everything, admins would have so little benefit knowing of such actions, so it'd just clutter the Stream list.

@fjarrett

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2014

@shadyvb Yes, that's certainly the counter-argument here, and it's definitely a valid one. But to answer your question, they could just by excluding the "Inactive Sidebar" context.

@shadyvb

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2014

Yea! didn't think of that. If they can filter/exclude it, then it'd only be natural to track everything and have users filter out what they do not want.
/five for the global exclusion settings idea!

@desaiuditd

This comment has been minimized.

Copy link
Contributor Author

commented Feb 26, 2014

👍 to @fjarrett
Though even I think a concrete scope for the plugin needs to be defined, as the plugin will grow it is prone to face issues like this on a front and not just specific to any individual module.

@fjarrett

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2014

@desaiuditd You are clear to go ahead and proceed with this issue! And thanks for reporting it. /five

@fjarrett fjarrett closed this Mar 10, 2014

@desaiuditd desaiuditd removed their assignment Sep 1, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.