Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete not working correctly in Exclude IP Addressees field #335

Closed
fjarrett opened this issue Mar 12, 2014 · 5 comments

Comments

Projects
None yet
2 participants
@fjarrett
Copy link
Contributor

commented Mar 12, 2014

The autocomplete functionality does not appear to be working in the Stream > Settings > Exclude > IP Addresses field.

screen shot 2014-03-12 at 6 12 06 pm

You are forced to type the entire IP before it will appear, so I think the period delimiters are causing a problem.

screen shot 2014-03-12 at 6 13 40 pm

@fjarrett fjarrett added the bug label Mar 12, 2014

@powelski powelski self-assigned this Mar 13, 2014

@powelski

This comment has been minimized.

Copy link

commented Mar 13, 2014

@fjarrett This behavior doesn't have anything to do with period delimiters. It occurs, because IP regex is being checked while you type and the suggestion appears once IP address is valid. What is expected here:

  1. Should the list of results be prefilled with IP addresses of existing logs (sorted by the number of logs perhaps)

or

  1. There should be no suggestions at all?
@fjarrett

This comment has been minimized.

Copy link
Contributor Author

commented Mar 13, 2014

@powelski The expected behavior would be:

  1. The results would be preloaded with all the IP addresses previously logged, sorted numerically.
  2. As you type, the results would narrow.
  3. You should be able to enter any IP, not just those that have been logged before. When this is the case, then the IP should be validated with regex before it can be added.
@powelski

This comment has been minimized.

Copy link

commented Mar 13, 2014

@fjarrett Does numerically mean same thing as one mentioned by me before (the number of logs)?

@fjarrett

This comment has been minimized.

Copy link
Contributor Author

commented Mar 13, 2014

@powelski No, it means by value of the first section of the IP.

50.xxx
192.xxx
207.xxx

@fjarrett

This comment has been minimized.

Copy link
Contributor Author

commented Mar 24, 2014

@powelski FYI issues will close automatically once the PR is merged into master. So the issue will remain open until it has been included in a public release.

@fjarrett fjarrett reopened this Mar 24, 2014

@fjarrett fjarrett closed this Mar 25, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.