Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date ranges should honor the site timezone setting #353

Closed
fjarrett opened this issue Mar 22, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@fjarrett
Copy link
Contributor

commented Mar 22, 2014

Currently, the date ranges are based solely on UTC.

An offset should be applied to these date ranges so that they honor the local timezone setting of the site.

screen_shot_2014-03-21_at_11_29_10_pm

My site's local time is UTC -0500

screen shot 2014-03-21 at 11 22 40 pm

@fjarrett fjarrett added the bug label Mar 22, 2014

@lukecarbis

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2014

Also, should we display the dates using get_option( 'date_format' ) (instead of Y/m/d)?

@fjarrett

This comment has been minimized.

Copy link
Contributor Author

commented Mar 27, 2014

@lukecarbis I don't think so, I believe that setting is more for themes to use on the front end. If you look at the default post list table screen the Date column format is always Y/m/d regardless of this setting.

@fjarrett fjarrett added the PR issued label Mar 27, 2014

fjarrett added a commit that referenced this issue Mar 28, 2014

Merge pull request #370 from lukecarbis/issue-353
Issue #353: Date Ranges should honour timezone settings.

@fjarrett fjarrett closed this Mar 31, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.