Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live updates are not respecting Excluded activity settings #355

Closed
fjarrett opened this issue Mar 22, 2014 · 1 comment

Comments

Projects
None yet
2 participants
@fjarrett
Copy link
Contributor

commented Mar 22, 2014

One of the features of the Exclude tab (see #251) was to also exclude matching records from appearing in the Stream Records (see #223).

However, if you have recent activity already in the DB that is suddenly excluded, those records will come flying in if the Live Update option is turned on.

  1. Make some changes to your site to generate a few records
  2. Go to Stream > Settings > Exclude and exclude yourself (or your role) from being tracked
  3. Visit the Stream Records screen with Live Update enabled
  4. At first your activity will be hidden and then suddenly the next live update will bring it in

screen_shot_2014-03-22_at_11_57_35_am

screen_shot_2014-03-22_at_1_07_41_pm

@fjarrett fjarrett added the bug label Mar 22, 2014

@powelski powelski assigned powelski and unassigned powelski Mar 25, 2014

fjarrett added a commit that referenced this issue Mar 27, 2014

Merge pull request #362 from faishal/master
Apply filter to query args Fix #355

@fjarrett fjarrett closed this in 4b20bd9 Mar 27, 2014

@fjarrett

This comment has been minimized.

Copy link
Contributor Author

commented Apr 2, 2014

Additional scope was added to this issue in the #362 pull request. We have now added a Visibility option to leave the decision to hide past records up to the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.