Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database Update may cause error when invoked from Updates screen #443

Closed
fjarrett opened this issue Apr 24, 2014 · 4 comments

Comments

Projects
None yet
2 participants
@fjarrett
Copy link
Contributor

commented Apr 24, 2014

In some cases, when clicking the Update Database button while on the Dashboard > Updates screen, a wp_die error occurs.

@fjarrett fjarrett added the bug label Apr 24, 2014

@jonathanbardo

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2014

When you click update database, the form redirects you to the calling page which might be wrong in some cases. I experienced an issue where I would click update on the plugin page and it would redirect me on a completely different page after.

@fjarrett

This comment has been minimized.

Copy link
Contributor Author

commented Apr 24, 2014

The problem might be coming from the use of wp_get_referer() here: https://github.com/x-team/wp-stream/blob/b3f0a76edf45fab842ec8f1c8e80266a692397ba/includes/install.php#L168

See this ticket in Trac: https://core.trac.wordpress.org/ticket/2858

Even though this bug was fixed years ago, it seems to be exactly what we are experiencing.

@fjarrett

This comment has been minimized.

Copy link
Contributor Author

commented Apr 24, 2014

Fixed as part of #449 in L199. Will be fully resolved when that PR is merged.

Props @c3mdigital

@fjarrett fjarrett closed this Apr 24, 2014

@fjarrett

This comment has been minimized.

Copy link
Contributor Author

commented Apr 24, 2014

Actually, this was fixed in dbe4465. Props @westonruter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.