Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP Warning when deleting network users #579

Closed
jeremyfelt opened this issue Jun 23, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@jeremyfelt
Copy link

commented Jun 23, 2014

I get the following when deleting network users as part of a bulk actioin from wp-admin/network/users.php:

Warning: implode(): Invalid arguments passed in /var/www/wp-content/plugins/wp-stream-dev/connectors/users.php on line 324

callback_deleted_users() is trying to implode the return of get_role_labels() for a user, but that user no longer exists so NULL is returned.

I have some other custom stuff going on, but I don't see anywhere that I'm hooked into the user deletion process, so I think this would happen anywhere. Happy to troubleshoot or dig more if needed.

This also results in records that look like this:

screen shot 2014-06-23 at 1 09 25 pm

@shadyvb

This comment has been minimized.

Copy link
Contributor

commented Jun 24, 2014

The fix in 0c110ce should clear the error message, as AFAIK no roles are associated to network users, only site users have those.

@shadyvb

This comment has been minimized.

Copy link
Contributor

commented Jun 24, 2014

@lukecarbis We should also handle the issue of 'update_count' setting was updated.

lukecarbis added a commit that referenced this issue Jun 25, 2014

Merge pull request #581 from x-team/hotfix-user-deletion-roles
Return array instead of null if found no roles for a deleted user #579

@shadyvb shadyvb closed this in #583 Jun 27, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.