Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Revision ID associated to record is not the most recent one #585

Closed
shadyvb opened this issue Jun 27, 2014 · 4 comments

Comments

Projects
None yet
2 participants
@shadyvb
Copy link
Contributor

commented Jun 27, 2014

Posts connector stores revision_id meta var for updated posts, so you can view changes and later be able to restore them quickly.

The tracking action happens before the revision is actually inserted, resulting in revision_id being always one revision earlier.

@shadyvb

This comment has been minimized.

Copy link
Contributor Author

commented Jul 20, 2014

@fjarrett as described in 0496628#commitcomment-7072242 , i think we need to rollback #593 and take into account that wp_transition_post_status can be used directly.

@shadyvb shadyvb reopened this Jul 20, 2014

@fjarrett

This comment has been minimized.

Copy link
Contributor

commented Jul 21, 2014

@shadyvb It's unfortunate that this was already merged and released publicly without knowing your full thoughts on the PR.

@shadyvb

This comment has been minimized.

Copy link
Contributor Author

commented Jul 21, 2014

@fjarrett Sorry for that, though we probably still need to address this sometime, as it might be a breaking change for some - custom - connectors.

@fjarrett

This comment has been minimized.

Copy link
Contributor

commented Jul 22, 2014

@shadyvb #593 PR reverted from develop in c9b171a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.