Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better compact search filters #403

Merged
merged 2 commits into from Apr 13, 2014

Conversation

Projects
None yet
2 participants
@fjarrett
Copy link
Contributor

commented Apr 11, 2014

This is a simpler continuation of #378.

@fjarrett

This comment has been minimized.

Copy link
Contributor Author

commented Apr 11, 2014

@lukecarbis Please review. I think a total revamp could come later, but this is just an attempt to use a much simpler approach to make the filters more attractive on 13" screens soon.

If you could provide screenshots of what this looks like on your small screen that would be great too.

@lukecarbis

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2014

This is from a 13" MacBook Air.

screen shot 2014-04-12 at 8 39 48 pm

screen shot 2014-04-12 at 8 40 18 pm

@fjarrett

This comment has been minimized.

Copy link
Contributor Author

commented Apr 13, 2014

I'm pleased with those results, and that it could be achieved with such small code changes. Merging this.

fjarrett added a commit that referenced this pull request Apr 13, 2014

@fjarrett fjarrett merged commit 3f83458 into develop Apr 13, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@fjarrett fjarrett deleted the compact-search-filters-2 branch Apr 13, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.