Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track Akismet spam checks, reflect on comment addition log #472 #587

Merged
merged 3 commits into from Jul 8, 2014

Conversation

Projects
None yet
2 participants
@shadyvb
Copy link
Contributor

commented Jun 29, 2014

Fixes #472 by properly detecting Akismet response on new comments, and reflecting on new comment log comment_type added in #558. So users now should be able to filter auto-spammed comment easily.

@fjarrett @lukecarbis Please review/test.

/cc @krogsgard Can you checkout this branch and confirm this solves your issue on #472 ?

// Auto-marked spam comments
if ( class_exists( 'Akismet' ) && Akismet::matches_last_comment( $comment ) ) {
$ak_last_comment = Akismet::get_last_comment();
if ( $ak_last_comment['akismet_result'] == 'true' ) {

This comment has been minimized.

Copy link
@fjarrett

fjarrett Jun 30, 2014

Contributor

@shadyvb Needs to be Yoda style

$ak_last_comment = Akismet::get_last_comment();
if ( 'true' == $ak_last_comment['akismet_result'] ) {
$is_spam = true;
$comment_status = __( 'marked as spam', 'stream' );

This comment has been minimized.

Copy link
@fjarrett

fjarrett Jun 30, 2014

Contributor

@shadyvb I think we should also add some Steam meta here as well as indicate in the summary that Akismet had involvement with the action.

screen_shot_2014-06-30_at_1_03_20_pm

@fjarrett

This comment has been minimized.

Copy link
Contributor

commented on f2d2a05 Jun 30, 2014

@shadyvb Very nice.

@fjarrett

This comment has been minimized.

Copy link
Contributor

commented Jul 7, 2014

I've got this branch installed on my personal site (which gets a lot of spam). I will see how it goes over the next several days and report back here with the results.

@fjarrett

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2014

This is working great! Ready for merge.

screen shot 2014-07-08 at 12 34 59 pm

fjarrett added a commit that referenced this pull request Jul 8, 2014

Merge pull request #587 from x-team/issue-472
Track Akismet spam checks, reflect on comment addition log #472

@fjarrett fjarrett merged commit 5abc963 into develop Jul 8, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@fjarrett fjarrett deleted the issue-472 branch Jul 8, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.