Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better localisation #644

Merged
merged 10 commits into from Oct 1, 2014

Conversation

Projects
None yet
2 participants
@lukecarbis
Copy link
Contributor

commented Oct 1, 2014

This PR removes all non-stream text domains!

Two things to note:

  1. Where we are referring specifically to something which is occurring in another plugin, I'm using _x with that plugin's slug for context
  2. I have not added any additional context where we are referring to WordPress core, because that's the default context, anyway. For example, _x( 'Posts', 'default', 'stream' ) is not very helpful.

@ThemeBoy @deckerweb - I'd love to get your thoughts on this approach.

@fjarrett please review. It would be great to release this with 2.0.1.

fjarrett added a commit that referenced this pull request Oct 1, 2014

@fjarrett fjarrett merged commit dcfd036 into develop Oct 1, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@fjarrett fjarrett deleted the stream-underscore-underscore branch Oct 1, 2014

@fjarrett

This comment has been minimized.

Copy link
Contributor

commented Oct 1, 2014

Nice work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.