Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream 3: Fix \WP_Stream\List_Table namespace so live updates work correctly #739

Merged
merged 1 commit into from Aug 26, 2015

Conversation

Projects
None yet
2 participants
@rob
Copy link
Contributor

commented Aug 26, 2015

(Reposting from #735 to issue PR against develop branch instead of master)

On a fresh Stream 3 install, live updates fail silently with the following error:

PHP Fatal error:  Class 'WP_Stream\\WP_Stream_List_Table' not found in /[...]/wp-content/plugins/stream/classes/class-live-update.php on line 179

Due to PHP's namespaces, this needs to be \WP_Stream\List_Table or just List_Table, not WP_Stream_List_Table. This commit fixes this so live updates work correctly again like they should.

fix List_Table namespace so live updates work correctly
Fixes "PHP Fatal error:  Class 'WP_Stream\\WP_Stream_List_Table' not found" error.
@lukecarbis

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2015

Legend. Thanks for this! 👌

lukecarbis pushed a commit that referenced this pull request Aug 26, 2015

Luke Carbis
Merge pull request #739 from rob/fix-live-updates
Stream 3: Fix \WP_Stream\List_Table namespace so live updates work correctly

@lukecarbis lukecarbis merged commit 10324de into xwp:develop Aug 26, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rob rob deleted the rob:fix-live-updates branch Sep 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.