Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gravity Forms connector update - bugfix/issue-771 #780

Merged
merged 15 commits into from Nov 6, 2015

Conversation

Projects
None yet
2 participants
@rob
Copy link
Contributor

commented Oct 7, 2015

This PR extends #779 with some more fixes. (also see #771)

FYI: All of the current GF export/import tracking functionality is broken in Stream. There's no longer a way to track form exports (and this was causing a bug - see below), and the actions for exporting entries and importing forms has changed. This commit fixes export/import tracking.

I also bumped PLUGIN_MIN_VERSION due to the new gform_forms_post_import action introduced in 1.9.13.29 (latest stable release.)

I discovered a bug in the current version. The gform_export_form line (which is actually a filter, not action) was causing the Gravity Forms .json export file to be empty. After removing that line, exports are working fine.

@lukecarbis

This comment has been minimized.

Copy link
Contributor

commented Oct 16, 2015

Hey @rob - where are we at with this?

@rob

This comment has been minimized.

Copy link
Contributor Author

commented Oct 16, 2015

Hi @lukecarbis - sorry, almost done (busy work week at my 'normal' job.) I will hopefully have everything committed tonight!

rob added some commits Oct 20, 2015

@lukecarbis

This comment has been minimized.

Copy link
Contributor

commented Oct 27, 2015

@rob Ready for me to test?

@rob

This comment has been minimized.

Copy link
Contributor Author

commented Oct 29, 2015

Hi @lukecarbis - sorry for the delays, my day job has been very busy lately. I did manage to do some work and clean up a lot of stuff, and it should work as it stands right now without any errors. But there's still some actions and other stuff I want to go over and clean up still, so it's your call.

lukecarbis pushed a commit that referenced this pull request Nov 6, 2015

Luke Carbis
Merge pull request #780 from rob/bugfix/issue-771
Gravity Forms connector update - bugfix/issue-771

@lukecarbis lukecarbis merged commit 0e24231 into xwp:bugfix/issue-771 Nov 6, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lukecarbis lukecarbis referenced this pull request Nov 6, 2015

Closed

Feature request #786

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.