Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update list table design at smaller screen size #810

Merged
merged 3 commits into from Feb 26, 2016

Conversation

Projects
None yet
2 participants
@lukecarbis
Copy link
Contributor

commented Dec 18, 2015

Resolves #804.

@ocean90 Please review, let me know if this works for you. :)

@lukecarbis

This comment has been minimized.

Copy link
Contributor Author

commented Feb 10, 2016

@chacha Can you please review this PR?

@chacha

This comment has been minimized.

Copy link
Contributor

commented Feb 18, 2016

@lukecarbis Could not reproduce in trunk. Could reproduce in stable. Functionally it works.

I looked to see if there was a simple way we could make this happen without using the !important, but given the complexity of the overriding rule, I think its the best solution here.

@chacha

This comment has been minimized.

Copy link
Contributor

commented Feb 18, 2016

Created bugfix/issue-804a that has been updated with the fixes to Travis.

@lukecarbis

This comment has been minimized.

Copy link
Contributor Author

commented Feb 26, 2016

@chacha - Travis fixes have been merged into develop, and I've merged develop into this branch. Anything else needed before I test / merge this fix?

@chacha

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2016

@lukecarbis I think you're good. I'll go ahead and delete the bugfix/issue-804a branch and you should be set to merge.

@lukecarbis

This comment has been minimized.

Copy link
Contributor Author

commented Feb 26, 2016

@chacha Made a couple of CSS changes - could you please test? If you and Travis are okay with it, please merge.

@chacha

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2016

Looks great! 👍

On Feb 25, 2016, at 8:44 PM, Luke Carbis notifications@github.com wrote:

@chacha https://github.com/chacha Made a couple of CSS changes - could you please test? If you and Travis are okay with it, please merge.


Reply to this email directly or view it on GitHub #810 (comment).

lukecarbis pushed a commit that referenced this pull request Feb 26, 2016

Luke Carbis
Merge pull request #810 from xwp/bugfix/issue-804
Update list table design at smaller screen size

@lukecarbis lukecarbis merged commit d4c4474 into develop Feb 26, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@lukecarbis lukecarbis deleted the bugfix/issue-804 branch Feb 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.