Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potentiel script name conflicts #812

Merged
merged 1 commit into from Dec 21, 2015

Conversation

Projects
None yet
2 participants
@stayallive
Copy link
Contributor

commented Dec 21, 2015

As discussed on PR #806 it would be better to rename the select2 and other third party libs to have a prefix to prevent the loading of scripts from another plugin.

@stayallive

This comment has been minimized.

Copy link
Contributor Author

commented Dec 21, 2015

Travis failing on PHP 7.0 and WP 3.9 :)

@lukecarbis

This comment has been minimized.

Copy link
Contributor

commented Dec 21, 2015

Thanks for the PR @stayallive. It's almost there. Can you please remove the npm-debug.log file?

@stayallive

This comment has been minimized.

Copy link
Contributor Author

commented Dec 21, 2015

Dang, don't know how that sneaked in, excuse me :) It's gone now.

lukecarbis pushed a commit that referenced this pull request Dec 21, 2015

Luke Carbis

@lukecarbis lukecarbis merged commit 4f23c3a into xwp:develop Dec 21, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.