Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging changes of settings in Customizer #827

Merged
merged 3 commits into from Mar 10, 2016

Conversation

Projects
None yet
3 participants
@lukecarbis
Copy link
Contributor

commented Mar 10, 2016

Resolves #308.

Thanks @marcin-lawrowski for finding this. I've tested it and it works well.

@westonruter Would you mind reviewing this one-liner? Any unintended side-effects?

Luke Carbis
@westonruter

This comment has been minimized.

Copy link
Contributor

commented Mar 10, 2016

Using the customize_save action is a good way to capture whether the setting updates are being made in the Customizer, yes: https://github.com/xwp/wordpress-develop/blob/deaabdcc28bfbdc78d90040ece81250563b84779/src/wp-includes/class-wp-customize-manager.php#L999-L1020

The PHPDoc will need to be updated from:

Trigger this connector from WP CLI, only for known Settings

@lukecarbis

This comment has been minimized.

Copy link
Contributor Author

commented Mar 10, 2016

Good catch. Thanks @westonruter.

lukecarbis pushed a commit that referenced this pull request Mar 10, 2016

Luke Carbis
Merge pull request #827 from xwp/bugfix/issue-308
Logging changes of settings in Customizer

@lukecarbis lukecarbis merged commit 3d5140c into develop Mar 10, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@lukecarbis lukecarbis deleted the bugfix/issue-308 branch Mar 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.