Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order status log for WooCommerce >= 2.2 #851

Merged
merged 1 commit into from Jul 27, 2016

Conversation

Projects
None yet
2 participants
@jamesgol
Copy link
Contributor

commented May 26, 2016

Per https://woocommerce.wordpress.com/2014/08/07/wc-2-2-order-statuses-plugin-compatibility/ WooCommerce switched from using a taxonomy for shop_order_status to using post_status.

Fix order status log for WooCommerce >= 2.2
Per https://woocommerce.wordpress.com/2014/08/07/wc-2-2-order-statuses-plugin-compatibility/ WooCommerce switched from using a taxonomy for shop_order_status to using post_status.
@jamesgol

This comment has been minimized.

Copy link
Contributor Author

commented May 26, 2016

While trying to understand how everything works in the plugin I decided to look at some existing connectors and noticed this wasn't working on my recent version of WooCommerce.

@jamesgol

This comment has been minimized.

Copy link
Contributor Author

commented May 26, 2016

I'm not convinced that strtolower is desired on the names or that the status should be passed as the log action. Might be nicer to pass 'updated' as the action (or at least the non strtolower'd version)

@lukecarbis lukecarbis merged commit ed02eda into xwp:develop Jul 27, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lukecarbis

This comment has been minimized.

Copy link
Contributor

commented Jul 27, 2016

Thanks @jamesgol - see 4b46c55 and 9560e3c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.