Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing Stream for Alternate Database Drivers #889

Merged
merged 29 commits into from Feb 15, 2017

Conversation

Projects
None yet
6 participants
@lukecarbis
Copy link
Contributor

commented Oct 31, 2016

See #881.

Moving here for extra work and testing.

eugenekireev and others added some commits Dec 15, 2015

Luke Carbis
Merge pull request #808 from evgenykireev/vip
abstracted db class interface, so it is configurable
Luke Carbis
Merge branch 'develop' into vip
Conflicts:
	classes/class-db.php
	classes/class-query.php
Faison Zutavern
DB Driver Tests - Removed the contsruction test from test-class-db.ph…
…p, since that work was moved a level deeper
Make the default driver class (WPDB) use the setup_storage and purge_…
…storage functions. These run the same install and uninstall functionality the plugin already has in place, but since it's now calling it from the Driver class, it can be overridden by other drivers.
Luke Carbis
Merge pull request #881 from 10up/feature/db-driver
Preparing Stream for Alternate Database Drivers

@lukecarbis lukecarbis self-assigned this Oct 31, 2016

@lukecarbis

This comment has been minimized.

Copy link
Contributor Author

commented Oct 31, 2016

@dkotter Have you got an example Stream Add-On that uses the wp_stream_db_driver filter to attach a different database driver?

@lukecarbis lukecarbis modified the milestone: 3.1.2 Nov 2, 2016

@lukecarbis

This comment has been minimized.

Copy link
Contributor Author

commented Nov 7, 2016

@dkotter ping.

@dkotter

This comment has been minimized.

Copy link
Contributor

commented Nov 7, 2016

So we do have one that we are working on at 10up, but currently it's in a private repo. I believe we were waiting for these changes to land in Stream first before making that public, because without these changes, the plugin itself won't do anything.

Once these changes are live and we've thoroughly tested our plugin, we'll be happy to make that public and that can be used as an example of how to build an add-on.

@lukecarbis

This comment has been minimized.

Copy link
Contributor Author

commented Nov 7, 2016

@dkotter I've reached out on WP Slack. If you could get me a copy to test this branch out privately - even if its a stripped back basic version - that would be much appreciated.

@lukecarbis

This comment has been minimized.

Copy link
Contributor Author

commented Dec 6, 2016

Ping @dkotter

@tlovett1

This comment has been minimized.

Copy link
Contributor

commented Jan 6, 2017

@lukecarbis we just sent you an invite to the repo.

@lukecarbis lukecarbis merged commit c284f36 into develop Feb 15, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@lukecarbis lukecarbis deleted the db-driver branch Feb 15, 2017

@tlovett1

This comment has been minimized.

Copy link
Contributor

commented Mar 6, 2017

Hey @lukecarbis when will this make it into a released version?

@lukecarbis

This comment has been minimized.

Copy link
Contributor Author

commented Mar 15, 2017

Today. :)

@Japh

This comment has been minimized.

Copy link

commented Mar 15, 2017

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.